This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG08665b180568: Support tilezero intrinsic and c interface for
AMX. (authored by LuoYuanke).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
LuoYuanke updated this revision to Diff 314170.
LuoYuanke added a comment.
Rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92837/new/
https://reviews.llvm.org/D92837
Files:
clang/include/clang/Basic/BuiltinsX86_64.def
clang/lib/Headers/a
pengfei accepted this revision.
pengfei added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92837/new/
https://reviews.llvm.org/D92837
__
LuoYuanke updated this revision to Diff 314157.
LuoYuanke added a comment.
Add avx512f in test case.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92837/new/
https://reviews.llvm.org/D92837
Files:
clang/include/clang/Basic/BuiltinsX86_64.def
c
LuoYuanke updated this revision to Diff 314087.
LuoYuanke added a comment.
Rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92837/new/
https://reviews.llvm.org/D92837
Files:
clang/include/clang/Basic/BuiltinsX86_64.def
clang/lib/Headers/a
LuoYuanke updated this revision to Diff 311375.
LuoYuanke added a comment.
a. Change tilezero back to be chained.
1. It avoid copy if several tilezero are same. Copy is expensive in AMX.
2. To keep the original order of amx intrinsics.
b. Refactor __tilezero interface.
Repository:
rG LLVM Gi
LuoYuanke updated this revision to Diff 310786.
LuoYuanke added a comment.
Address Pengfei's comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92837/new/
https://reviews.llvm.org/D92837
Files:
clang/include/clang/Basic/BuiltinsX86_64.def
LuoYuanke added inline comments.
Comment at: llvm/lib/Target/X86/X86ExpandPseudo.cpp:499
+MI.RemoveOperand(3); // Remove $tmmcfg
+for (int i = 2; i > 0; --i)
+ MI.RemoveOperand(i);
pengfei wrote:
> Can change to i = 3?
Yes, then remove line 498.
==
pengfei added inline comments.
Comment at: llvm/lib/Target/X86/X86ExpandPseudo.cpp:499
+MI.RemoveOperand(3); // Remove $tmmcfg
+for (int i = 2; i > 0; --i)
+ MI.RemoveOperand(i);
Can change to i = 3?
Comment at: llvm/lib/Target/X86
LuoYuanke created this revision.
Herald added subscribers: pengfei, hiraditya.
LuoYuanke requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D92837
Files:
clan
10 matches
Mail list logo