This revision was automatically updated to reflect the committed changes.
Closed by commit rG3fa2d37eb3f8: [clangd][NFC] Improve clangd status messages
(authored by qchateau, committed by sammccall).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
sammccall added a comment.
It's up to you - it's easy for me/others to land them on your behalf. Having
your own commit access gives you more control, ability to deal with build
breakages quickly, fix trivial things without review etc.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
qchateau added a comment.
Sure !
Email: quentin.chat...@gmail.com
I guess I'll need to ask for commit access
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93546/new/
https://reviews.llvm.org/D93546
___
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks, LG - want me to land it?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93546/new/
https://reviews.llvm.org/D93546
qchateau updated this revision to Diff 313079.
qchateau added a comment.
- dont capitalize first letter of status
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93546/new/
https://reviews.llvm.org/D93546
Files:
sammccall added a comment.
Thanks! Changes to ClangdServer are definitely good, I'm less sure about
renderTUAction.
Comment at: clang-tools-extra/clangd/TUScheduler.cpp:1183
// are familiar by C++ programmers.
std::string renderTUAction(const PreambleAction PA, const
qchateau created this revision.
qchateau added a reviewer: sammccall.
Herald added subscribers: usaxena95, kadircet, arphaman, javed.absar.
qchateau requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang.
clangd actions have
