[PATCH] D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc5e7e649d537: [AArch64][Clang][Linux] Enable out-of-line atomics by default. (authored by ilinpv). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default.

ilinpv updated this revision to Diff 320142. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93585/new/ https://reviews.llvm.org/D93585 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default.

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Thanks, LGTM too. One nit inlined that can be addressed before committing. Comment at: clang/test/Driver/aarch64-features.c:47 +// CHECK-OUTLINE-ATOMICS-ON:

[PATCH] D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default.

ilinpv updated this revision to Diff 320123. ilinpv added a comment. Tests for "-m[no]outline-atomics" options added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93585/new/ https://reviews.llvm.org/D93585 Files:

[PATCH] D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default.

t.p.northover added a comment. I think this looks good now, modulo Sjoerd's last comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93585/new/ https://reviews.llvm.org/D93585 ___ cfe-commits mailing

[PATCH] D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default.

SjoerdMeijer added a comment. Sorry one last question: how about `-mno-outline-atomics` in combination with this? Think we need to add a test for that too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93585/new/ https://reviews.llvm.org/D93585

[PATCH] D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default.

ilinpv updated this revision to Diff 319951. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93585/new/ https://reviews.llvm.org/D93585 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default.

SjoerdMeijer added a comment. In D93585#2526774 , @ilinpv wrote: > Clang driver tests for outline atomics were added. Thanks! Is there a way we can test `-rtlib=libgcc`? Comment at: clang/lib/Driver/ToolChains/Linux.cpp:855 +

[PATCH] D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default.

ilinpv updated this revision to Diff 319693. ilinpv added a comment. Clang driver tests for outline atomics were added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93585/new/ https://reviews.llvm.org/D93585 Files:

[PATCH] D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default.

SjoerdMeijer added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6448 + CmdArgs.push_back("-target-feature"); + CmdArgs.push_back("+outline-atomics"); +} This needs a Clang driver tests. Repository: rG LLVM Github Monorepo

[PATCH] D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default.

ilinpv added a comment. @t.p.northover sorry for pinging you, do you have any concerns about latest patch? It enables outline atomics by default on Aarch64/Linux/Clang with libraries check. I am hoping to get this in before LLVM 12 branch. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default.

ilinpv updated this revision to Diff 317849. ilinpv retitled this revision from "[AArch64] Enable out-of-line atomics by default." to "[AArch64][Clang][Linux] Enable out-of-line atomics by default.". ilinpv edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE