This revision was automatically updated to reflect the committed changes.
Closed by commit rG6b4e8f82a3f8: [clangd] Use dirty filesystem when performing
cross file tweaks (authored by njames93).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
njames93 updated this revision to Diff 338518.
njames93 added a comment.
Fix up compilation failures and test failures.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93978/new/
https://reviews.llvm.org/D93978
Files:
njames93 updated this revision to Diff 338294.
njames93 marked 4 inline comments as done.
njames93 added a comment.
Address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93978/new/
https://reviews.llvm.org/D93978
Files:
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Herald added a project: clang-tools-extra.
Sorry, I thought this had already gone in!
LG, sorry for the back and forth.
Comment at:
njames93 added inline comments.
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:575
return CB(InpAST.takeError());
-auto Selections = tweakSelection(Sel, *InpAST);
+// FIXME: Should we use the dirty fs here?
+auto FS = TFS.view(llvm::None);
njames93 updated this revision to Diff 329649.
njames93 added a comment.
Rebased.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93978/new/
https://reviews.llvm.org/D93978
Files:
clang-tools-extra/clangd/ClangdServer.cpp
