[PATCH] D94039: [WebAssembly] Update WasmEHPrepare for the new spec

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9724c3cff46f: [WebAssembly] Update WasmEHPrepare for the new spec (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D94039: [WebAssembly] Update WasmEHPrepare for the new spec

aheejin updated this revision to Diff 315392. aheejin marked an inline comment as done. aheejin added a comment. Delete `declare void @_ZSt9terminatev()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94039/new/ https://reviews.llvm.org/D94039

[PATCH] D94039: [WebAssembly] Update WasmEHPrepare for the new spec

aheejin marked an inline comment as done. aheejin added a comment. In D94039#2480002 , @tlively wrote: > In the description I think "but LLVM does not have a way of that kind of > behavior" is missing the word "modeling" => "but LLVM does not have a way

[PATCH] D94039: [WebAssembly] Update WasmEHPrepare for the new spec

tlively added inline comments. Comment at: llvm/lib/CodeGen/WasmEHPrepare.cpp:374-375 + // be lowered to wasm 'catch' instruction. We do this mainly because + // instruction selection cannot handle wasm.get.exception intrinsic's token + // argument. + Instruction *CatchCI =

[PATCH] D94039: [WebAssembly] Update WasmEHPrepare for the new spec

dschuff added inline comments. Comment at: llvm/lib/CodeGen/WasmEHPrepare.cpp:374-375 + // be lowered to wasm 'catch' instruction. We do this mainly because + // instruction selection cannot handle wasm.get.exception intrinsic's token + // argument. + Instruction *CatchCI =

[PATCH] D94039: [WebAssembly] Update WasmEHPrepare for the new spec

tlively added a comment. In the description I think "but LLVM does not have a way of that kind of behavior" is missing the word "modeling" => "but LLVM does not have a way of modeling that kind of behavior" Comment at: llvm/lib/CodeGen/WasmEHPrepare.cpp:374-375 + // be

[PATCH] D94039: [WebAssembly] Update WasmEHPrepare for the new spec

aheejin created this revision. aheejin added reviewers: dschuff, tlively. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. aheejin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.