[PATCH] D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.

martong added a comment. @balazske Thanks Balázs! Great work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94067/new/ https://reviews.llvm.org/D94067 ___ cfe-commits mailing list

[PATCH] D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2901 + // Skip the declaration if injected type is already set. + if (isa(RI->getTypeForDecl())) +continue; shafik

[PATCH] D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0877b963ef2d: [clang][ASTImporter] Fix a possible assertion failure… (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94067/new/

[PATCH] D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.

balazske updated this revision to Diff 315055. balazske added a comment. Removing unrelated (for the bug fix) change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94067/new/ https://reviews.llvm.org/D94067 Files: clang/lib/AST/ASTImporter.cpp

[PATCH] D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2901 + // Skip the declaration if injected type is already set. + if (isa(RI->getTypeForDecl())) +continue; balazske wrote: > shafik wrote: > > Is this to fix

[PATCH] D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2901 + // Skip the declaration if injected type is already set. + if (isa(RI->getTypeForDecl())) +continue; shafik wrote: > Is this to fix the bug or is this

[PATCH] D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2901 + // Skip the declaration if injected type is already set. + if (isa(RI->getTypeForDecl())) +continue; Is this to fix the bug or is this for efficiency

[PATCH] D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.

balazske updated this revision to Diff 314604. balazske added a comment. Found a better solution. And the decl chain looks more normal if this change is used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94067/new/ https://reviews.llvm.org/D94067

[PATCH] D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.

balazske added a comment. Order of previous declarations may get confusable: ClassTemplateDecl1 <-(Prev)- ClassTemplateDecl2 <-(Prev)- ClassTemplateDecl3 | | | | | CXXRecorddDecl1 <-- CXXRecordDecl2 -(Prev)-> CXXRecordDecl3 - |

[PATCH] D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.

balazske added a comment. The exact call chain, if the added test is called without the fix: $ ./tools/clang/unittests/AST/ASTTests --gtest_filter='*HasNoDescribedTemplateSet*' Note: Google Test filter = *HasNoDescribedTem* [==] Running 4 tests from 1 test case. [--]

[PATCH] D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.

balazske created this revision. Herald added subscribers: martong, teemperor, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The