[PATCH] D94123: [NVPTX] Fix debugging information being added to NVPTX target if remarks are enabled

2021-01-06 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D94123#2482636 , @MaskRay wrote: > If you use `arc diff`, you can obtain `Reviewed-by:` line from Phabricator. > It is more useful than `Reviewers: ` (a list of reviewers do not mean they > endorse or accept the patch) `arc

[PATCH] D94123: [NVPTX] Fix debugging information being added to NVPTX target if remarks are enabled

2021-01-06 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. If you use `arc diff`, you can obtain `Reviewed-by:` line from Phabricator. It is more useful than `Reviewers: ` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94123/new/ https://reviews.llvm.org/D94123 ___

[PATCH] D94123: [NVPTX] Fix debugging information being added to NVPTX target if remarks are enabled

2021-01-06 Thread Joseph Huber via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1ca5e68aa07e: [NVPTX] Fix debugging information being added to NVPTX target if remarks areā€¦ (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D94123: [NVPTX] Fix debugging information being added to NVPTX target if remarks are enabled

2021-01-06 Thread Artem Belevich via Phabricator via cfe-commits
tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94123/new/ https://reviews.llvm.org/D94123 ___ cfe-co

[PATCH] D94123: [NVPTX] Fix debugging information being added to NVPTX target if remarks are enabled

2021-01-06 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. OK with me, @tra ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94123/new/ https://reviews.llvm.org/D94123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D94123: [NVPTX] Fix debugging information being added to NVPTX target if remarks are enabled

2021-01-06 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 updated this revision to Diff 314899. jhuber6 retitled this revision from "[NVPTX] Strip debugging symbols for optimized NVPTX targets." to "[NVPTX] Fix debugging information being added to NVPTX target if remarks are enabled". jhuber6 edited the summary of this revision. jhuber6 added a