[PATCH] D94376: [MemCpyOpt] Enable MemorySSA by default

2021-05-14 Thread Melanie Blower via Phabricator via cfe-commits
mibintc added a comment. In my premerge testing, I see this fail which looks like the check string is incorrect: command stderr: C:\ws\w16e2-2\llvm-project\premerge-checks\llvm\test\Other\new-pm-lto-defaults.ll:84:21: error: CHECK-O23SZ-NEXT: expected string not found in input ;

[PATCH] D94376: [MemCpyOpt] Enable MemorySSA by default

2021-02-22 Thread Mikael Holmén via Phabricator via cfe-commits
uabelho added a comment. In D94376#2579242 , @nikic wrote: > @uabelho Thanks for the report! This issue should be resolved by > https://github.com/llvm/llvm-project/commit/4125afc35723b490556f7a38f7835f0914f70292. Yep, thanks! Repository: rG LLVM

[PATCH] D94376: [MemCpyOpt] Enable MemorySSA by default

2021-02-22 Thread Nikita Popov via Phabricator via cfe-commits
nikic added a comment. @uabelho Thanks for the report! This issue should be resolved by https://github.com/llvm/llvm-project/commit/4125afc35723b490556f7a38f7835f0914f70292. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94376/new/

[PATCH] D94376: [MemCpyOpt] Enable MemorySSA by default

2021-02-22 Thread Mikael Holmén via Phabricator via cfe-commits
uabelho added a comment. I ran into a crash in memcpyopt with this patch. Running opt -S -o - bbi-53212.ll -memcpyopt yields opt: ../include/llvm/Support/Casting.h:104: static bool llvm::isa_impl_cl::doit(const From *) [To = llvm::MemoryUse, From = const llvm::MemoryUseOrDef *]:

[PATCH] D94376: [MemCpyOpt] Enable MemorySSA by default

2021-02-19 Thread Nikita Popov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. nikic marked an inline comment as done. Closed by commit rG71a8e4e7d6b9: [MemCopyOpt] Enable MemorySSA by default (authored by nikic). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to