[PATCH] D94403: [RISCV] Implement new architecture extension macros

This revision was automatically updated to reflect the committed changes. Closed by commit rG666815d61bc2: [RISCV] Implement new architecture extension macros (authored by simoncook). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94403/new/

[PATCH] D94403: [RISCV] Implement new architecture extension macros

kito-cheng accepted this revision. kito-cheng added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94403/new/ https://reviews.llvm.org/D94403 ___ cfe-commits mailing list

[PATCH] D94403: [RISCV] Implement new architecture extension macros

simoncook updated this revision to Diff 318869. simoncook added a comment. - Update to bitmanip 0.93 - Expand and support vector as per workaround in D95146 - Add negative testing (check __riscv_b not defined for just subextension) Repository: rG LLVM Github

[PATCH] D94403: [RISCV] Implement new architecture extension macros

kito-cheng added a comment. In D94403#2512232 , @asb wrote: > @kito-cheng could you please confirm that this patch handles sub-extensions > in the same way GCC does. i.e. -march=rv32izbb0p92 defines `__riscv_zbb` but > NOT `__riscv_b`? Yes :)

[PATCH] D94403: [RISCV] Implement new architecture extension macros

kito-cheng accepted this revision. kito-cheng added a comment. I believe the behavior has aligned to GCC now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94403/new/ https://reviews.llvm.org/D94403 ___

[PATCH] D94403: [RISCV] Implement new architecture extension macros

asb added a comment. @kito-cheng could you please confirm that this patch handles sub-extensions in the same way GCC does. i.e. -march=rv32izbb0p92 defines `__riscv_zbb` but NOT `__riscv_b`? That seems logical to me, as otherwise it would be cumbersome to check if the whole extension is

[PATCH] D94403: [RISCV] Implement new architecture extension macros

simoncook updated this revision to Diff 317591. simoncook added a comment. Have 'b'/'v' features imply subfeatures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94403/new/ https://reviews.llvm.org/D94403 Files: clang/lib/Basic/Targets/RISCV.cpp

[PATCH] D94403: [RISCV] Implement new architecture extension macros

kito-cheng added a comment. Just note how current GCC implemented, GCC implement that like implied extension, e.g. `V` implied `Zvamo` and `Zvlsseg`, so `__riscv_zvamo` is naturally defined when `V`-ext is enabled. Comment at: clang/lib/Basic/Targets/RISCV.cpp:148 + if

[PATCH] D94403: [RISCV] Implement new architecture extension macros

simoncook updated this revision to Diff 317409. simoncook added a comment. Rebase on D94930 to show updated version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94403/new/ https://reviews.llvm.org/D94403 Files:

[PATCH] D94403: [RISCV] Implement new architecture extension macros

simoncook added a comment. In D94403#2504046 , @kito-cheng wrote: > Thanks you implement that on clang, I think it's really great to included > that in LLVM 12 release. > > I would like to define marco for sub-extension too, I know that's my fault, I >

[PATCH] D94403: [RISCV] Implement new architecture extension macros

kito-cheng added a comment. That's my fault, I didn't specify the behavior of sub-extension clearly on the spec, but I think it would be great if we also define sub-extension marcos, since it would be easier to check when some core only implement sub-extension, and the code can just check the

[PATCH] D94403: [RISCV] Implement new architecture extension macros

khchen accepted this revision. khchen added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94403/new/ https://reviews.llvm.org/D94403 ___

[PATCH] D94403: [RISCV] Implement new architecture extension macros

HsiangKai added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94403/new/ https://reviews.llvm.org/D94403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D94403: [RISCV] Implement new architecture extension macros

simoncook updated this revision to Diff 315805. simoncook added a comment. Correct constant used in macros, 2.0 should be 200 not 2000 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94403/new/ https://reviews.llvm.org/D94403 Files:

[PATCH] D94403: [RISCV] Implement new architecture extension macros

simoncook created this revision. simoncook added reviewers: asb, luismarques, kito-cheng. Herald added subscribers: frasercrmck, NickHung, evandro, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,