This revision was automatically updated to reflect the committed changes.
Closed by commit rG127091bfd5ed: [CUDA] Normalize handling of defauled dtor.
(authored by tra).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94732/new/
https://reviews.llvm.o
tra updated this revision to Diff 318052.
tra added a comment.
Added a test for the corner case Richard has pointed out in the comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94732/new/
https://reviews.llvm.org/D94732
Files:
clang/lib/Se
tra updated this revision to Diff 318018.
tra added a comment.
Removed unneeded changes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94732/new/
https://reviews.llvm.org/D94732
Files:
clang/lib/Sema/SemaCUDA.cpp
clang/lib/Sema/SemaExprCXX.cpp
tra added inline comments.
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:15162-15170
+ bool SkipDtorChecks = VD->getType()->isArrayType();
+
+ // CUDA: Skip destructor checks for host-only variables during device-side
+ // compilation
+ SkipDtorChecks |=
+ (LangOpts.CUDAIsD
rsmith added inline comments.
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:15162-15170
+ bool SkipDtorChecks = VD->getType()->isArrayType();
+
+ // CUDA: Skip destructor checks for host-only variables during device-side
+ // compilation
+ SkipDtorChecks |=
+ (LangOpts.CUDA
tra added inline comments.
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:15162-15170
+ bool SkipDtorChecks = VD->getType()->isArrayType();
+
+ // CUDA: Skip destructor checks for host-only variables during device-side
+ // compilation
+ SkipDtorChecks |=
+ (LangOpts.CUDAIsD
tra updated this revision to Diff 317946.
tra added a comment.
Addressed Richard's comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94732/new/
https://reviews.llvm.org/D94732
Files:
clang/lib/Sema/SemaCUDA.cpp
clang/lib/Sema/SemaDeclCXX
rsmith added inline comments.
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:15162-15170
+ bool SkipDtorChecks = VD->getType()->isArrayType();
+
+ // CUDA: Skip destructor checks for host-only variables during device-side
+ // compilation
+ SkipDtorChecks |=
+ (LangOpts.CUDA
tra created this revision.
tra added reviewers: HAPPY, yaxunl.
Herald added a subscriber: bixia.
tra requested review of this revision.
Herald added a project: clang.
Defaulted destructor was treated inconsistently, compared to other
compiler-generated functions.
When Sema::IdentifyCUDATarget()
