[PATCH] D94745: [OpenMP][deviceRTLs] Build the deviceRTLs with OpenMP instead of target dependent language

tianshilei1992 added a comment. In D94745#2539661 , @protze.joachim wrote: > In D94745#2539454 , @JonChesterfield > wrote: > >> I think there's a bug report about this. Sycl (iirc) introduced a change >> that

[PATCH] D94745: [OpenMP][deviceRTLs] Build the deviceRTLs with OpenMP instead of target dependent language

protze.joachim added a comment. Sorry, I meant to disable building of the cuda device-runtime, or whatever is breaking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94745/new/ https://reviews.llvm.org/D94745

[PATCH] D94745: [OpenMP][deviceRTLs] Build the deviceRTLs with OpenMP instead of target dependent language

protze.joachim added a comment. In D94745#2539454 , @JonChesterfield wrote: > I think there's a bug report about this. Sycl (iirc) introduced a change that > caught invalid things with types that were previously ignored. @jdoerfert is > on point I

[PATCH] D94745: [OpenMP][deviceRTLs] Build the deviceRTLs with OpenMP instead of target dependent language

JonChesterfield added a comment. I think there's a bug report about this. Sycl (iirc) introduced a change that caught invalid things with types that were previously ignored. @jdoerfert is on point I think. `-DLLVM_ENABLE_PROJECTS="clang;compiler-rt;libcxxabi;libcxx;libunwind;openmp" ` ^ That

[PATCH] D94745: [OpenMP][deviceRTLs] Build the deviceRTLs with OpenMP instead of target dependent language

jdoerfert added a comment. In D94745#2539405 , @protze.joachim wrote: > For me this patch breaks building llvm. Before this patch, I successfully > built llvm using a llvm/10 installation on the system. What is probably > special with our llvm

[PATCH] D94745: [OpenMP][deviceRTLs] Build the deviceRTLs with OpenMP instead of target dependent language

protze.joachim added a comment. For me this patch breaks building llvm. Before this patch, I successfully built llvm using a llvm/10 installation on the system. What is probably special with our llvm installation is that we by default use libc++ rather than libstdc++. FAILED:

[PATCH] D94745: [OpenMP][deviceRTLs] Build the deviceRTLs with OpenMP instead of target dependent language

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7c03f7d7d04c: [OpenMP][deviceRTLs] Build the deviceRTLs with OpenMP instead of target… (authored by tianshilei1992). Repository: rG LLVM Github

[PATCH] D94745: [OpenMP][deviceRTLs] Build the deviceRTLs with OpenMP instead of target dependent language

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. LGTM! Thank you for iterating on this, and for trying to keep amdgpu working. With this patch, the devicertl no longer needs the cuda sdk installed to compile. I believe