[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain skeleton for AMDGPU

pdhaliwal updated this revision to Diff 317810. pdhaliwal added a comment. Herald added a subscriber: mgorny. > Won't this just prevent us from building clang due to the missing cmake > changes? It compiles and builds fine, however, I wasn't actually aware such sanity checking being present.

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain skeleton for AMDGPU

ABataev added a comment. In D94961#2506460 , @JonChesterfield wrote: > This patch was written, roughly, by: > > - copying the known-working openmp driver from rocm into the trunk source tree > - deleting lots of stuff that didn't look necessary > -

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain skeleton for AMDGPU

jdoerfert added a comment. Won't this just prevent us from building clang due to the missing cmake changes? We need somewhat testable chunks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94961/new/ https://reviews.llvm.org/D94961

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain skeleton for AMDGPU

pdhaliwal updated this revision to Diff 317553. pdhaliwal added a comment. Fix clang-tidy error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94961/new/ https://reviews.llvm.org/D94961 Files: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain skeleton for AMDGPU

JonChesterfield added a comment. This patch was written, roughly, by: - copying the known-working openmp driver from rocm into the trunk source tree - deleting lots of stuff that didn't look necessary - deleting some stuff that is broadly necessary, but the specifics are up for debate The idea

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain skeleton for AMDGPU

pdhaliwal created this revision. pdhaliwal added reviewers: jdoerfert, grokos, JonChesterfield, ronlieb, ABataev. Herald added subscribers: kerbowa, guansong, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl. pdhaliwal requested review of this revision. Herald added subscribers: