[PATCH] D94979: [CGExpr] Use getCharWidth() more consistently in ConstantAggregateBuilderUtils. NFC

2021-01-21 Thread Bjorn Pettersson via Phabricator via cfe-commits
bjope updated this revision to Diff 318135. bjope added a comment. Updated to add CharTy to the CodeGenTypeCache (based on review feedback). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94979/new/ https://reviews.llvm.org/D94979 Files:

[PATCH] D94979: [CGExpr] Use getCharWidth() more consistently in ConstantAggregateBuilderUtils. NFC

2021-01-20 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. I don't mind generally abstracting Clang to handle this better. Comment at: clang/lib/CodeGen/CodeGenModule.h:1229 + // Return the LLVM type sized as one character unit. + llvm::Type *getCharSizedType(); + Please just add a CharTy