[PATCH] D95001: [CodeView] Emit function types in -gline-tables-only.

MaskRay added a comment. In your commit the message does not include `Reviewed by:`. Many people agree that both `Reviewed by:` & `Differential Revision:` should be present. The `Reviewed by:` list indicates people who acknowledged the patch. (The `Reviewers:` list does not necessarily mean

[PATCH] D95001: [CodeView] Emit function types in -gline-tables-only.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa3d7cee7f9bd: [CodeView] Emit function types in -gline-tables-only. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D95001: [CodeView] Emit function types in -gline-tables-only.

akhuang updated this revision to Diff 317975. akhuang added a comment. Add comments describing reason for emitting types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95001/new/ https://reviews.llvm.org/D95001 Files:

[PATCH] D95001: [CodeView] Emit function types in -gline-tables-only.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good! Might be worth some comments explaining why it's being done this way (probably good to have some details wherever we're making these changes to cope with CV's need for

[PATCH] D95001: [CodeView] Emit function types in -gline-tables-only.

akhuang updated this revision to Diff 317728. akhuang added a comment. Update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95001/new/ https://reviews.llvm.org/D95001 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D95001: [CodeView] Emit function types in -gline-tables-only.

akhuang added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-gline-tables-only-codeview.cpp:30-32 + // CHECK: !DISubprogram(name: "operator()", scope: ![[LAMBDA:[0-9]+]] + // CHECK: ![[LAMBDA]] = !DICompositeType(tag: DW_TAG_class_type, + // CHECK-SAME:

[PATCH] D95001: [CodeView] Emit function types in -gline-tables-only.

dblaikie added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-gline-tables-only-codeview.cpp:30-32 + // CHECK: !DISubprogram(name: "operator()", scope: ![[LAMBDA:[0-9]+]] + // CHECK: ![[LAMBDA]] = !DICompositeType(tag: DW_TAG_class_type, + // CHECK-SAME:

[PATCH] D95001: [CodeView] Emit function types in -gline-tables-only.

akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1050-1052 + // Don't include a linkage name in line tables only, except to differentiate + // between lambdas. + if (CGM.getCodeGenOpts().hasReducedDebugInfo() || RD->isLambda())

[PATCH] D95001: [CodeView] Emit function types in -gline-tables-only.

akhuang updated this revision to Diff 317718. akhuang marked an inline comment as done. akhuang added a comment. Add check for CodeView Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95001/new/ https://reviews.llvm.org/D95001 Files:

[PATCH] D95001: [CodeView] Emit function types in -gline-tables-only.

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1050-1052 + // Don't include a linkage name in line tables only, except to differentiate + // between lambdas. + if (CGM.getCodeGenOpts().hasReducedDebugInfo() || RD->isLambda())

[PATCH] D95001: [CodeView] Emit function types in -gline-tables-only.

akhuang updated this revision to Diff 317701. akhuang added a comment. Remove lambda change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95001/new/ https://reviews.llvm.org/D95001 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D95001: [CodeView] Emit function types in -gline-tables-only.

rnk added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1050-1052 + // Don't include a linkage name in line tables only, except to differentiate + // between lambdas. + if (CGM.getCodeGenOpts().hasReducedDebugInfo() || RD->isLambda()) We

[PATCH] D95001: [CodeView] Emit function types in -gline-tables-only.

akhuang created this revision. akhuang added reviewers: rnk, dblaikie. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change adds function types to further differentiate between FUNC_IDs in -gline-tables-only. Size increase