[PATCH] D95166: Disable rosegment for old Android versions.

danalbert added a comment. In D95166#2540705 , @thakis wrote: > In D95166#2540399 , @danalbert wrote: > >>> We've since added -fuse-ld=lld to the three CMAKE_*_FLAGS so I think we're >>> likely set on our end. >>

[PATCH] D95166: Disable rosegment for old Android versions.

thakis added a comment. In D95166#2540399 , @danalbert wrote: >> We've since added -fuse-ld=lld to the three CMAKE_*_FLAGS so I think we're >> likely set on our end. > > https://reviews.llvm.org/D76452 not being accepted means that Android > toolchains

[PATCH] D95166: Disable rosegment for old Android versions.

danalbert added a comment. > We've since added -fuse-ld=lld to the three CMAKE_*_FLAGS so I think we're > likely set on our end. https://reviews.llvm.org/D76452 not being accepted means that Android toolchains must have LLD installed as `ld`. I'm guessing this thread has shown that the patch

[PATCH] D95166: Disable rosegment for old Android versions.

thakis added a comment. In D95166#2531194 , @danalbert wrote: > In D95166#2530791 , @thakis wrote: > >> Landed revert in 1608ba09462d877111230e9461b895f696f8fcb1 >>

[PATCH] D95166: Disable rosegment for old Android versions.

danalbert added a comment. In D95166#2530791 , @thakis wrote: > Landed revert in 1608ba09462d877111230e9461b895f696f8fcb1 > . > Someone should file a PR to make sure that gets merged

[PATCH] D95166: Disable rosegment for old Android versions.

thakis added a comment. Alternatively, there's `LinkerIsLLD` in the driver code, maybe the driver wants to check that in some way (if only to emit a better diag if it's false, I guess) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95166/new/

[PATCH] D95166: Disable rosegment for old Android versions.

thakis added a comment. Landed revert in 1608ba09462d877111230e9461b895f696f8fcb1 . Someone should file a PR to make sure that gets merged to the 12.0 branch. We can then reland on trunk once there are clear instructions for

[PATCH] D95166: Disable rosegment for old Android versions.

thakis added a comment. This breaks us too: https://bugs.chromium.org/p/chromium/issues/detail?id=1172291 Given that this breaks at least 3 distinct build configs, let's revert this for now until we've figured out a path forward. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D95166: Disable rosegment for old Android versions.

danalbert added a comment. In D95166#2529412 , @dmajor wrote: > It does feel kind of awkward to me that _this_ is the patch that ends up > breaking the builds, versus something at the cmake level that says "you are > explicitly unsupported". If you're

[PATCH] D95166: Disable rosegment for old Android versions.

glandium added a comment. Firefox CI is using a custom clang, but uses a NDK otherwise (an old-ish one, clearly older than r22 which is the first that defaults to lld). And we do pass -fuse-ld=bfd at the moment for $reasons. If clang _really_ wants to assume lld as the linker for android, then

[PATCH] D95166: Disable rosegment for old Android versions.

dmajor added a comment. It does feel kind of awkward to me that _this_ is the patch that ends up breaking the builds, versus something at the cmake level that says "you are explicitly unsupported". Also it's unfortunate that this landed just hours before 12.0.0 branched. Had it landed

[PATCH] D95166: Disable rosegment for old Android versions.

danalbert added a comment. In D95166#2527437 , @vitalybuka wrote: > Our Android build bot is broken after this patch > http://lab.llvm.org:8011/#/builders/77/builds/3234 Shouldn't that build be using lld? In D95166#2526839

[PATCH] D95166: Disable rosegment for old Android versions.

vitalybuka added a comment. Out Android build bot is broken after this patch http://lab.llvm.org:8011/#/builders/77/builds/3234 Run Build Command(s):/usr/bin/ninja cmTC_578f8 && [1/2] Building C object CMakeFiles/cmTC_578f8.dir/testCCompiler.c.o [2/2] Linking C executable cmTC_578f8

[PATCH] D95166: Disable rosegment for old Android versions.

glandium added a comment. "Android only supports lld" might be true now, but it hasn't always been true, which means the change is not backwards compatible with versions of the NDK that don't use lld. Also, `-fuse-ld` is still a valid flag that can allow to use a different linker than lld.

[PATCH] D95166: Disable rosegment for old Android versions.

danalbert added a comment. In D95166#2525131 , @dmajor wrote: > Firefox has a build break from this change. In certain Android configurations > we use bfd or gold. The statement in the commit message "Android only > supports LLD" is news to me, could

[PATCH] D95166: Disable rosegment for old Android versions.

dmajor added a comment. Firefox has a build break from this change. In certain Android configurations we use bfd or gold. The statement in the commit message "Android only supports LLD" is news to me, could you point me to any references for this? Repository: rG LLVM Github Monorepo

[PATCH] D95166: Disable rosegment for old Android versions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfae16fc0eed7: Disable rosegment for old Android versions. (authored by danalbert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95166/new/

[PATCH] D95166: Disable rosegment for old Android versions.

danalbert created this revision. danalbert added a reviewer: srhines. danalbert added a project: clang. danalbert requested review of this revision. The unwinder used by the crash handler on versions of Android prior to API 29 did not correctly handle binaries built with rosegment, which is