[PATCH] D95536: [clang][sema] Note decl location on missing member

tbaeder abandoned this revision. tbaeder added a comment. Abandoning this since it's probably not worth it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95536/new/ https://reviews.llvm.org/D95536 ___ cfe-commits mailing list

[PATCH] D95536: [clang][sema] Note decl location on missing member

aaron.ballman added a comment. In D95536#2568252 , @tbaeder wrote: > In D95536#2557197 , @aaron.ballman > wrote: > >> Hmm... I feel like the diagnostic should already be sufficient to locate the >> originating

[PATCH] D95536: [clang][sema] Note decl location on missing member

tbaeder added a comment. In D95536#2557197 , @aaron.ballman wrote: > Hmm... I feel like the diagnostic should already be sufficient to locate the > originating location of the class or namespace and the note is adding a bit > more (almost, but not

[PATCH] D95536: [clang][sema] Note decl location on missing member

aaron.ballman added a comment. In D95536#2553325 , @tbaeder wrote: > In D95536#2552258 , @aaron.ballman > wrote: > >> In D95536#2551332 , @tbaeder wrote: >> >>> Any update

[PATCH] D95536: [clang][sema] Note decl location on missing member

tbaeder added a comment. In D95536#2552258 , @aaron.ballman wrote: > In D95536#2551332 , @tbaeder wrote: > >> Any update on this? > > Thank you for the patch! Do you have some motivating examples of when this >

[PATCH] D95536: [clang][sema] Note decl location on missing member

aaron.ballman added a comment. In D95536#2551332 , @tbaeder wrote: > Any update on this? Thank you for the patch! Do you have some motivating examples of when this would really add clarity to the diagnostic? I'm not opposed to the patch per se, but I'm

[PATCH] D95536: [clang][sema] Note decl location on missing member

tbaeder added a comment. Any update on this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95536/new/ https://reviews.llvm.org/D95536 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D95536: [clang][sema] Note decl location on missing member

tbaeder updated this revision to Diff 319820. tbaeder added a comment. Fixed the Lambda oddity as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95536/new/ https://reviews.llvm.org/D95536 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/Sema.cpp

[PATCH] D95536: [clang][sema] Note decl location on missing member

tbaeder updated this revision to Diff 319780. tbaeder added a comment. Answered one of my questions by adding a new function directly to `Sema`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95536/new/ https://reviews.llvm.org/D95536 Files: clang/include/clang/Sema/Sema.h

[PATCH] D95536: [clang][sema] Note decl location on missing member

tbaeder updated this revision to Diff 319671. tbaeder added a comment. Forgot clang-format of course, sorry. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95536/new/ https://reviews.llvm.org/D95536 Files: clang/lib/Sema/SemaExpr.cpp clang/lib/Sema/SemaExprMember.cpp

[PATCH] D95536: [clang][sema] Note decl location on missing member

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, rsmith, rjmccall, rtrieu. Herald added subscribers: lxfind, jdoerfert. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Hi, when trying to access a member of a