This revision was automatically updated to reflect the committed changes.
yaxunl marked an inline comment as done.
Closed by commit rG0b2af1a28894: [NFC][CUDA] Refactor registering device
variable (authored by yaxunl).
Herald added a project: clang.
Changed prior to commit:
tra added a comment.
LGTM.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4270-4271
} else {
- // Host-side shadows of external declarations of device-side
- // global variables become internal definitions. These have to
- // be internal in order to
yaxunl marked 3 inline comments as done.
yaxunl added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4270-4271
} else {
- // Host-side shadows of external declarations of device-side
- // global variables become internal definitions. These have
tra added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4270-4271
} else {
- // Host-side shadows of external declarations of device-side
- // global variables become internal definitions. These have to
- // be internal in order to prevent
yaxunl marked 2 inline comments as done.
yaxunl added inline comments.
Comment at: clang/lib/CodeGen/CGCUDANV.cpp:924
+
+void CGNVCUDARuntime::adjustShadowVarLinkage(
+const VarDecl *D, llvm::GlobalValue::LinkageTypes ) {
tra wrote:
> yaxunl wrote:
> > tra
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
Couple of minor nits LGTM otherwise,
Comment at: clang/lib/CodeGen/CGCUDANV.cpp:924
+
+void CGNVCUDARuntime::adjustShadowVarLinkage(
+const VarDecl *D,
yaxunl updated this revision to Diff 320526.
yaxunl marked 4 inline comments as done.
yaxunl added a comment.
Revised by Artem's comments
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95558/new/
https://reviews.llvm.org/D95558
Files:
clang/lib/CodeGen/CGCUDANV.cpp
yaxunl marked 4 inline comments as done.
yaxunl added inline comments.
Comment at: clang/lib/CodeGen/CGCUDANV.cpp:157
llvm::Function *makeModuleDtorFunction() override;
+ void
+ adjustShadowVarLinkage(const VarDecl *D,
tra wrote:
> clang-format it? `void`
tra added inline comments.
Comment at: clang/lib/CodeGen/CGCUDANV.cpp:157
llvm::Function *makeModuleDtorFunction() override;
+ void
+ adjustShadowVarLinkage(const VarDecl *D,
clang-format it? `void` hanging all by itself looks odd.
yaxunl created this revision.
yaxunl added a reviewer: tra.
yaxunl requested review of this revision.
Extract registering device variable to CUDA runtime codegen function since it
will be called in multiple places.
https://reviews.llvm.org/D95558
Files:
clang/lib/CodeGen/CGCUDANV.cpp
10 matches
Mail list logo
