[PATCH] D95561: [Clang] Introduce Swift async calling convention.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG92dcb1d2db8c: [Clang] Introduce Swift async calling convention. (authored by varungandhi-apple). Changed prior to commit:

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

varungandhi-apple updated this revision to Diff 354073. varungandhi-apple added a comment. Herald added a subscriber: ormris. Combined D95984 into this patch since all necessary LLVM patches have landed, so having the patches separated out is not helpful.

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

varungandhi-apple updated this revision to Diff 329883. varungandhi-apple added a comment. Permit swift_context and swift_indirect_result parameters for swiftasynccall functions. (Earlier, these were restricted to swiftcall-only.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95561/new/ https://reviews.llvm.org/D95561

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

varungandhi-apple updated this revision to Diff 326194. varungandhi-apple added a comment. Address review feedback; remove centralized target check for CC_SwiftAsync. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95561/new/

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

rjmccall added a comment. LGTM other than the TargetInfo thing. Comment at: clang/include/clang/Basic/TargetInfo.h:1424 + triple.isAArch64(); + } + As I commented in the other patch, I think this would be cleaner in the long term if you just

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

varungandhi-apple updated this revision to Diff 324389. varungandhi-apple added a comment. - Remove semantic restriction of swift_async_context being only applicable to swiftasynccall. - Update target checks to make sure we only allow supported targets. - Update doc comment. Repository: rG

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

varungandhi-apple updated this revision to Diff 323363. varungandhi-apple added a comment. Fix test case for debuginfo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95561/new/ https://reviews.llvm.org/D95561 Files:

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

varungandhi-apple added inline comments. Comment at: clang/test/CodeGen/debug-info-cc.c:60-66 +// [FIXME: swiftasynccc] Update debuginfo tag to SwiftAsync once LLVM support lands. +// LINUX: !DISubprogram({{.*}}"add_swiftasynccall", {{.*}}type: ![[FTY:[0-9]+]] +// LINUX:

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

varungandhi-apple updated this revision to Diff 321801. varungandhi-apple added a comment. Correct documentation on tail call behavior as pointed out by John. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95561/new/ https://reviews.llvm.org/D95561

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

rjmccall added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4409 + calls to other ``swiftasynccall`` functions must be in tail position + (in all language modes). In particular: + - For C, this implies that ``return async_f();`` (``async_f`` is another

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

varungandhi-apple updated this revision to Diff 321501. varungandhi-apple added a comment. 1. Update whitespace and add documentation for swiftasynccall. 2. Update commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95561/new/

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:8106-8115 + case ParsedAttr::AT_SwiftAsyncCall: case ParsedAttr::AT_VectorCall: case ParsedAttr::AT_MSABI: case ParsedAttr::AT_SysVABI: case ParsedAttr::AT_Pcs: case

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

varungandhi-apple added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:2711 + Out << 'T'; + break; case CC_PreserveMost: Out << 'U'; break; rjmccall wrote: > Please use consistent formatting with the other cases, here and

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

varungandhi-apple added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:8106-8115 + case ParsedAttr::AT_SwiftAsyncCall: case ParsedAttr::AT_VectorCall: case ParsedAttr::AT_MSABI: case ParsedAttr::AT_SysVABI: case ParsedAttr::AT_Pcs: case

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

rjmccall added a comment. Broadly LGTM Comment at: clang/include/clang/Basic/AttrDocs.td:4398 + let Content = [{ +TODO + }]; varungandhi-apple wrote: > I have left this as a TODO for now, so that it can be filled in later when > the exact details of the

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

varungandhi-apple added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:2688-2689 // ::= S # __attribute__((__swiftcall__)) // Clang-only + // ::= T # __attribute__((__swiftasynccall__)) // + //

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

dexonsmith added a comment. In D95561#2526417 , @varungandhi-apple wrote: > I don't get how you stack your change on top of someone else's change (the > diff seems to have been created with only one commit), but this depends on >

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

varungandhi-apple added a comment. I don't get how you stack your change on top of someone else's change (the diff seems to have been created with only one commit), but this depends on https://reviews.llvm.org/D95228, which depends on https://reviews.llvm.org/D95044. Repository: rG LLVM

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

varungandhi-apple added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4398 + let Content = [{ +TODO + }]; I have left this as a TODO for now, so that it can be filled in later when the exact details of the convention are implemented

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

varungandhi-apple created this revision. varungandhi-apple added reviewers: rjmccall, ahatanak. Herald added subscribers: dexonsmith, arphaman, kbarton, hiraditya, jgravelle-google, sbc100, nemanjai, dschuff. Herald added a reviewer: aaron.ballman. varungandhi-apple published this revision for