Anastasia added inline comments.
Herald added a subscriber: ldrumm.
Comment at: clang/test/SemaOpenCLCXX/address-space-templates.cl:60
+ // Preserve the address space of the type in forwarding reference.
+ // CHECK: CXXMethodDecl {{.*}} operator() 'void (__private int
bader added inline comments.
Comment at: clang/test/SemaOpenCLCXX/address-space-templates.cl:60
+ // Preserve the address space of the type in forwarding reference.
+ // CHECK: CXXMethodDecl {{.*}} operator() 'void (__private int &__private)
const __generic'
+ foo4(i,
This revision was automatically updated to reflect the committed changes.
Closed by commit rG0c65993be186: [OpenCL] Fix default address space in template
argument deduction. (authored by Anastasia).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95624/new/
https://reviews.llvm.org/D95624
___
cfe-commits mailing list
Anastasia updated this revision to Diff 320484.
Anastasia retitled this revision from "[OpenCL][PR48896] Add default address
space in template argument deduction only if missing" to "[OpenCL][PR48896] Fix
default address space in template argument deduction".
Anastasia edited the summary of this