[PATCH] D95691: Implement P2173 for attributes on lambdas

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit in b2bc0a32545f9b066fed1631c6fba92a2a5a6d84 and will work on a patch for the remainder of the diagnostic groups. Thanks for the reviews!

[PATCH] D95691: Implement P2173 for attributes on lambdas

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:269 +def CXXPre2BCompatPedantic : + DiagGroup<"c++98-c++11-c++14-c++17-c++20-compat-pedantic",

[PATCH] D95691: Implement P2173 for attributes on lambdas

rjmccall added a comment. Sorry. I have no problem with continuing the existing pattern, I guess. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95691/new/ https://reviews.llvm.org/D95691 ___ cfe-commits mailing list

[PATCH] D95691: Implement P2173 for attributes on lambdas

aaron.ballman added a comment. In D95691#2572114 , @aaron.ballman wrote: > In D95691#2545808 , @aaron.ballman > wrote: > >> Updated based on review feedback. > > Ping Ping CHANGES SINCE LAST ACTION

[PATCH] D95691: Implement P2173 for attributes on lambdas

aaron.ballman added a comment. In D95691#2545808 , @aaron.ballman wrote: > Updated based on review feedback. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95691/new/ https://reviews.llvm.org/D95691

[PATCH] D95691: Implement P2173 for attributes on lambdas

aaron.ballman updated this revision to Diff 321842. aaron.ballman added a comment. Updated based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95691/new/ https://reviews.llvm.org/D95691 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D95691: Implement P2173 for attributes on lambdas

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:269 +def CXXPre2BCompatPedantic : + DiagGroup<"c++98-c++11-c++14-c++17-c++20-compat-pedantic", [CXXPre2BCompat]>; rsmith wrote: > rjmccall wrote: > > rsmith wrote:

[PATCH] D95691: Implement P2173 for attributes on lambdas

rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:269 +def CXXPre2BCompatPedantic : + DiagGroup<"c++98-c++11-c++14-c++17-c++20-compat-pedantic", [CXXPre2BCompat]>; rjmccall wrote: > rsmith wrote: > > rjmccall wrote: > > >

[PATCH] D95691: Implement P2173 for attributes on lambdas

rjmccall added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:269 +def CXXPre2BCompatPedantic : + DiagGroup<"c++98-c++11-c++14-c++17-c++20-compat-pedantic", [CXXPre2BCompat]>; rsmith wrote: > rjmccall wrote: > > Quuxplusone wrote:

[PATCH] D95691: Implement P2173 for attributes on lambdas

rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:269 +def CXXPre2BCompatPedantic : + DiagGroup<"c++98-c++11-c++14-c++17-c++20-compat-pedantic", [CXXPre2BCompat]>; rjmccall wrote: > Quuxplusone wrote: > > aaron.ballman

[PATCH] D95691: Implement P2173 for attributes on lambdas

rjmccall added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:269 +def CXXPre2BCompatPedantic : + DiagGroup<"c++98-c++11-c++14-c++17-c++20-compat-pedantic", [CXXPre2BCompat]>; Quuxplusone wrote: > aaron.ballman wrote: > > rjmccall

[PATCH] D95691: Implement P2173 for attributes on lambdas

Quuxplusone added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:269 +def CXXPre2BCompatPedantic : + DiagGroup<"c++98-c++11-c++14-c++17-c++20-compat-pedantic", [CXXPre2BCompat]>; aaron.ballman wrote: > rjmccall wrote: > > Uh, I

[PATCH] D95691: Implement P2173 for attributes on lambdas

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:269 +def CXXPre2BCompatPedantic : + DiagGroup<"c++98-c++11-c++14-c++17-c++20-compat-pedantic", [CXXPre2BCompat]>; rjmccall wrote: > Uh, I think we're a couple

[PATCH] D95691: Implement P2173 for attributes on lambdas

rjmccall added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:269 +def CXXPre2BCompatPedantic : + DiagGroup<"c++98-c++11-c++14-c++17-c++20-compat-pedantic", [CXXPre2BCompat]>; Uh, I think we're a couple standard releases past the

[PATCH] D95691: Implement P2173 for attributes on lambdas

aaron.ballman added a comment. In D95691#2540667 , @rjmccall wrote: > In D95691#2540619 , @rsmith wrote: > >> In D95691#2540450 , @rjmccall wrote: >> >>> The warning is a

[PATCH] D95691: Implement P2173 for attributes on lambdas

aaron.ballman updated this revision to Diff 321465. aaron.ballman set the repository for this revision to rG LLVM Github Monorepo. aaron.ballman added a comment. Herald added a project: clang. Updating based on review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95691: Implement P2173 for attributes on lambdas

rjmccall added a comment. In D95691#2540619 , @rsmith wrote: > In D95691#2540450 , @rjmccall wrote: > >> The warning is a bit weird. If we don't think it's certain that the >> committee will adopt this syntax, I

[PATCH] D95691: Implement P2173 for attributes on lambdas

rsmith added a comment. In D95691#2540450 , @rjmccall wrote: > The patch seems technically okay to me. Do we need to recognize lambdas in > any tentative-parse situations, or is it always the reverse (e.g. recognizing > ObjC message sends as

[PATCH] D95691: Implement P2173 for attributes on lambdas

rjmccall added a comment. The patch seems technically okay to me. Do we need to recognize lambdas in any tentative-parse situations, or is it always the reverse (e.g. recognizing ObjC message sends as not-a-lambda)? The warning is a bit weird. If we don't think it's certain that the

[PATCH] D95691: Implement P2173 for attributes on lambdas

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, rjmccall, jyknight. aaron.ballman requested review of this revision. https://wg21.link/P2173 is making its way through WG21 currently and has not been formally adopted yet. This feature provides very useful functionality