[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

jsji added a comment. https://reviews.llvm.org/D97353 should fix the unitest failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95753/new/ https://reviews.llvm.org/D95753 ___ cfe-commits mailing

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

jsji added inline comments. Comment at: llvm/unittests/ProfileData/CoverageMappingTest.cpp:211 Expressions, Data.Regions); EXPECT_THAT_ERROR(Reader.read(), Succeeded()); } Somehow previous value of `Data.Filenames`

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

vsk added a comment. Just skimming, haven't had a chance to look closely. Comment at: llvm/unittests/ProfileData/CoverageMappingTest.cpp:149 if (R != Files.end()) return R->second; +unsigned Index = Files.size() + 1; assert(R->second > 0 &&

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

jsji added a comment. In D95753#2581150 , @phosek wrote: > In D95753#2578724 , @gregmiller > wrote: > >> Hello, we are seeing failures like below: >> >> Note: Google Test filter = >>

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

phosek added a comment. In D95753#2578724 , @gregmiller wrote: > Hello, we are seeing failures like below: > > Note: Google Test filter = > ParameterizedCovMapTest/CoverageMappingTest.skip_duplicate_function_record/0 > [==] Running 1 test from 1

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

gregmiller added a comment. Hello, we are seeing failures like below: Note: Google Test filter = ParameterizedCovMapTest/CoverageMappingTest.skip_duplicate_function_record/0 [==] Running 1 test from 1 test case. [--] Global test environment set-up. [--] 1 test from

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5fbd1a333aa1: [Coverage] Store compilation dir separately in coverage mapping (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

phosek updated this revision to Diff 324759. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95753/new/ https://reviews.llvm.org/D95753 Files: clang/include/clang/Basic/CodeGenOptions.h clang/include/clang/Driver/Options.td

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

phosek updated this revision to Diff 324755. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95753/new/ https://reviews.llvm.org/D95753 Files: clang/include/clang/Basic/CodeGenOptions.h clang/include/clang/Driver/Options.td

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG97ec8fa5bb07: [Coverage] Store compilation dir separately in coverage mapping (authored by phosek). Changed prior to commit:

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

phosek updated this revision to Diff 324733. phosek edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95753/new/ https://reviews.llvm.org/D95753 Files: clang/include/clang/Basic/CodeGenOptions.h

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

phosek updated this revision to Diff 324423. phosek marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95753/new/ https://reviews.llvm.org/D95753 Files: clang/include/clang/Basic/CodeGenOptions.h

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:1131 NegFlag, BothFlags<[CoreOption]>>; +def fcoverage_compilation_dir : Separate<["-"], "fcoverage-compilation-dir">, +Group, Flags<[CC1Option, CC1AsOption, CoreOption]>,

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

phosek added inline comments. Comment at: clang/include/clang/Driver/Options.td:1131 NegFlag, BothFlags<[CoreOption]>>; +def fcoverage_compilation_dir : Separate<["-"], "fcoverage-compilation-dir">, +Group, Flags<[CC1Option, CC1AsOption, CoreOption]>,

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

phosek updated this revision to Diff 324224. phosek marked an inline comment as done. phosek retitled this revision from "Store compilation dir separately in coverage mapping" to "[Coverage] Store compilation dir separately in coverage mapping". Repository: rG LLVM Github Monorepo CHANGES