[PATCH] D95771: [clang-tidy] fix modernize-loop-convert to retain needed array-like operator[]

njames93 added a comment. In D95771#2547467 , @poelmanc wrote: > Thanks for the commit, and thanks for the heads-up! I've now added the > address in my github account. Its updated now and the commit is linked to your account. Repository: rG LLVM

[PATCH] D95771: [clang-tidy] fix modernize-loop-convert to retain needed array-like operator[]

poelmanc added a comment. In D95771#2547366 , @njames93 wrote: > In D95771#2547160 , @poelmanc wrote: > >> In D95771#2547102 , @njames93 wrote: >> >>> Should this be

[PATCH] D95771: [clang-tidy] fix modernize-loop-convert to retain needed array-like operator[]

njames93 added a comment. In D95771#2547160 , @poelmanc wrote: > In D95771#2547102 , @njames93 wrote: > >> Should this be committed using `poelmanc `? > > That or `Conrad Poelman ` would be great, thanks. I

[PATCH] D95771: [clang-tidy] fix modernize-loop-convert to retain needed array-like operator[]

This revision was automatically updated to reflect the committed changes. Closed by commit rG5229edd66742: [clang-tidy] fix modernize-loop-convert to retain needed array-like operator[] (authored by poelmanc, committed by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D95771: [clang-tidy] fix modernize-loop-convert to retain needed array-like operator[]

poelmanc added a comment. In D95771#2547102 , @njames93 wrote: > Should this be committed using `poelmanc `? That or `Conrad Poelman ` would be great, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95771/new/

[PATCH] D95771: [clang-tidy] fix modernize-loop-convert to retain needed array-like operator[]

njames93 added a comment. Herald added a subscriber: nullptr.cpp. In D95771#2540598 , @poelmanc wrote: > @njames93 Thanks for the review and for accepting this revision. I lack > llvm-project commit access so if it's good to go I would greatly appreciate

[PATCH] D95771: [clang-tidy] fix modernize-loop-convert to retain needed array-like operator[]

poelmanc added a comment. @njames93 Thanks for the review and for accepting this revision. I lack llvm-project commit access so if it's good to go I would greatly appreciate it if you or someone could push this whenever you have have a chance. Thanks! CHANGES SINCE LAST ACTION

[PATCH] D95771: [clang-tidy] fix modernize-loop-convert to retain needed array-like operator[]

poelmanc updated this revision to Diff 320704. poelmanc marked an inline comment as done. poelmanc added a comment. Fix formatting, add suggested test case (which works.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95771/new/ https://reviews.llvm.org/D95771 Files:

[PATCH] D95771: [clang-tidy] fix modernize-loop-convert to retain needed array-like operator[]

njames93 edited reviewers, added: aaron.ballman, alexfh, njames93; removed: sammccall, hokein. njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM, Can you fix the formatting as well. Comment at:

[PATCH] D95771: [clang-tidy] fix modernize-loop-convert to retain needed array-like operator[]

poelmanc created this revision. poelmanc added reviewers: sammccall, hokein. poelmanc added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. poelmanc requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.