[PATCH] D95778: [OpenCL] Introduce new language options for OpenCL keywords.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa5b627aa4fe7: [OpenCL] Introduce new language options for OpenCL keywords. (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D95778: [OpenCL] Introduce new language options for OpenCL keywords.

Anastasia accepted this revision. Anastasia added a comment. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95778/new/ https://reviews.llvm.org/D95778 ___ cfe-commits mailing list

[PATCH] D95778: [OpenCL] Introduce new language options for OpenCL keywords.

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95778/new/ https://reviews.llvm.org/D95778 ___

[PATCH] D95778: [OpenCL] Introduce new language options for OpenCL keywords.

azabaznov updated this revision to Diff 321348. azabaznov added a comment. Renamed language options and adjusted comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95778/new/ https://reviews.llvm.org/D95778 Files:

[PATCH] D95778: [OpenCL] Introduce new language options for OpenCL keywords.

Anastasia added a comment. In D95778#2536598 , @azabaznov wrote: > In D95778#2536266 , @Anastasia wrote: > >>> LGTM, but perhaps you can add a test that has each keyword disabled? >> >> FYI we currently already

[PATCH] D95778: [OpenCL] Introduce new language options for OpenCL keywords.

svenvh added a comment. In D95778#2536266 , @Anastasia wrote: >> LGTM, but perhaps you can add a test that has each keyword disabled? > > FYI we currently already test that `pipe` and `generic` are valid for OpenCL > 2.0 and invalid for OpenCL < 2.0. Or

[PATCH] D95778: [OpenCL] Introduce new language options for OpenCL keywords.

azabaznov added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:218 LANGOPT(OpenCLCPlusPlusVersion , 32, 0, "C++ for OpenCL version") +LANGOPT(OpenCLGenericKeyword, 1, 0, "OpenCL generic keyword") +LANGOPT(OpenCLPipeKeyword , 1, 0, "OpenCL pipe

[PATCH] D95778: [OpenCL] Introduce new language options for OpenCL keywords.

azabaznov added a comment. In D95778#2536266 , @Anastasia wrote: >> LGTM, but perhaps you can add a test that has each keyword disabled? > > FYI we currently already test that `pipe` and `generic` are valid for OpenCL > 2.0 and invalid for OpenCL < 2.0.

[PATCH] D95778: [OpenCL] Introduce new language options for OpenCL keywords.

Anastasia added a comment. > LGTM, but perhaps you can add a test that has each keyword disabled? FYI we currently already test that `pipe` and `generic` are valid for OpenCL 2.0 and invalid for OpenCL < 2.0. Or do you mean different kind of tests? In OpenCL 3.0 we will have to set the new

[PATCH] D95778: [OpenCL] Introduce new language options for OpenCL keywords.

svenvh added a comment. LGTM, but perhaps you can add a test that has each keyword disabled? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95778/new/ https://reviews.llvm.org/D95778 ___ cfe-commits

[PATCH] D95778: [OpenCL] Introduce new language options for OpenCL keywords.

azabaznov updated this revision to Diff 320709. azabaznov added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95778/new/ https://reviews.llvm.org/D95778 Files: clang/include/clang/Basic/LangOptions.def

[PATCH] D95778: [OpenCL] Introduce new language options for OpenCL keywords.

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: dexonsmith, yaxunl. Herald added a reviewer: jansvoboda11. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. OpenCL keywords