This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG40c261c41c4c: [clang][cli] Generate and round-trip language
options (authored by jansvoboda11).
Changed prior to commit:
jansvoboda11 updated this revision to Diff 322106.
jansvoboda11 added a comment.
Add comment, remove unnecessary diff
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95793/new/
https://reviews.llvm.org/D95793
Files:
jansvoboda11 updated this revision to Diff 321135.
jansvoboda11 added a comment.
Revert reporting failure when parsing sanitizers
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95793/new/
https://reviews.llvm.org/D95793
Files:
jansvoboda11 updated this revision to Diff 321131.
jansvoboda11 added a comment.
Fix failures of tests that invoke -cc1 directly
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95793/new/
https://reviews.llvm.org/D95793
Files:
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
LGTM, since I don't think the parallel error paths are too bad in this specific
patch, but see my longer comment inline.
Comment at:
jansvoboda11 added inline comments.
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1196
const std::vector ,
DiagnosticsEngine , SanitizerSet ) {
+ bool Success = true;
dexonsmith wrote:
>
dexonsmith added inline comments.
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1196
const std::vector ,
DiagnosticsEngine , SanitizerSet ) {
+ bool Success = true;
Can the caller use
jansvoboda11 created this revision.
jansvoboda11 added reviewers: dexonsmith, Bigcheese.
Herald added subscribers: dang, mgorny.
jansvoboda11 requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: cfe-commits, sstefan1.
Herald added a project: clang.
This
