[PATCH] D95918: [Coverage] Propogate counter to condition of conditional operator

zequanwu added a comment. In D95918#2540367 , @vsk wrote: > How was the issue spotted? If there was a crash or an incorrect coverage bug > that's not triggered by one of the existing frontend tests, it'd be worth > adding a regression test. If the

[PATCH] D95918: [Coverage] Propogate counter to condition of conditional operator

vsk added a comment. How was the issue spotted? If there was a crash or an incorrect coverage bug that's not triggered by one of the existing frontend tests, it'd be worth adding a regression test. If the problem can't be replicated without involving llvm-cov, this can be an integration test.

[PATCH] D95918: [Coverage] Propogate counter to condition of conditional operator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4dc08cc3aa41: [Coverage] Propogate counter to condition of conditional operator (authored by zequanwu). Repository: rG LLVM Github Monorepo

[PATCH] D95918: [Coverage] Propogate counter to condition of conditional operator

zequanwu added a comment. I tested it locally. They are all passed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95918/new/ https://reviews.llvm.org/D95918 ___ cfe-commits mailing list

[PATCH] D95918: [Coverage] Propogate counter to condition of conditional operator

rnk added a comment. Nice. I believe there are some integration tests in compiler-rt/test/profile. First, please run them and make sure they pass. Second, @vsk, do you think it's worth adding an integration test for this, seeing as the bug is really only observable when you put all the

[PATCH] D95918: [Coverage] Propogate counter to condition of conditional operator

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95918/new/ https://reviews.llvm.org/D95918

[PATCH] D95918: [Coverage] Propogate counter to condition of conditional operator

zequanwu created this revision. zequanwu added reviewers: vsk, rnk. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang usually propagates counter mapping region for conditions of `if`, `while`, `for`, etc from parent counter.