[PATCH] D95942: [clangd] Deduplicate scopes in IncludeFixer queries

This revision was automatically updated to reflect the committed changes. Closed by commit rGd1978fa4bf0d: [clangd] Deduplicate scopes in IncludeFixer queries (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95942/new/

[PATCH] D95942: [clangd] Deduplicate scopes in IncludeFixer queries

kadircet updated this revision to Diff 321120. kadircet added a comment. - add back the global scope. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95942/new/ https://reviews.llvm.org/D95942 Files: clang-tools-extra/clangd/IncludeFixer.cpp

[PATCH] D95942: [clangd] Deduplicate scopes in IncludeFixer queries

kadircet updated this revision to Diff 321118. kadircet added a comment. Herald added a subscriber: mgrang. - sort+unique+erase instead of using a set - Inline visitor and directly collect scopes there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95942: [clangd] Deduplicate scopes in IncludeFixer queries

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/IncludeFixer.cpp:322 - Scopes.push_back(""); + std::set Scopes; + Scopes.insert(""); nit:

[PATCH] D95942: [clangd] Deduplicate scopes in IncludeFixer queries

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo