Re: [PATCH] D9600: Add scan-build python implementation

rizsotto.mailinglist added a comment. Thank you guys for your review and help! The latest patch is commited. Let's do the next steps too. ;) @danielmarjamaki the standalone Bear will be maintained. and your comments will also be considered. http://reviews.llvm.org/D9600

Re: [PATCH] D9600: Add scan-build python implementation

dcoughlin closed this revision. dcoughlin added a comment. This was committed in r257533. Thanks Laszlo! http://reviews.llvm.org/D9600 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D9600: Add scan-build python implementation

zaks.anna accepted this revision. zaks.anna added a comment. Laszlo, I am very excited about having the new and much improved scan-build in tree! It will serve as a solid foundation for moving forward. Thank you for all your hard work! Anna. http://reviews.llvm.org/D9600

Re: [PATCH] D9600: Add scan-build python implementation

dcoughlin added a comment. Hi Laszlo, I've run scan-build-py with both environment-variable-based and library-based interposition on our open source benchmark suite and it looks like it is in great shape on Darwin! There are still some remaining issues with xcodebuild, but I will help fix

Re: [PATCH] D9600: Add scan-build python implementation

danielmarjamaki added a comment. I like the standalone bear tool. should it really be embedded into clang? Will the standalone tool still be maintained? Comment at: tools/scan-build-py/libear/ear.c:1 @@ +1,2 @@ +/* -*- coding: utf-8 -*- +// The LLVM

Re: [PATCH] D9600: Add scan-build python implementation

rizsotto.mailinglist added a comment. sorry for the delay, hard to get free time these days. ;) Comment at: tools/scan-build-py/libscanbuild/intercept.py:146 @@ +145,3 @@ +}) +elif sys.platform == 'darwin': +logging.debug('intercept gonna preload libear on

Re: [PATCH] D9600: Add scan-build python implementation

rgov added a subscriber: rgov. rgov added a comment. I tried out intercept-build and found it very easy to use. I tried running it on projects that compile with both make and xcodebuild and it worked for both. Thanks for contributing this tool. http://reviews.llvm.org/D9600

Re: [PATCH] D9600: Add scan-build python implementation

dcoughlin added a comment. Thanks for adding `bear_get_environment()` to handle the environment weirdness on Darwin. Comment at: tools/scan-build-py/libscanbuild/intercept.py:146 @@ +145,3 @@ +}) +elif sys.platform == 'darwin': +logging.debug('intercept

Re: [PATCH] D9600: Add scan-build python implementation

rizsotto.mailinglist added inline comments. Comment at: tools/scan-build-py/libear/ear.c:142 @@ +141,3 @@ +#endif +if (!initialized) +initialized = bear_capture_env_t(_env); dcoughlin wrote: > rizsotto.mailinglist wrote: > > rizsotto.mailinglist

Re: [PATCH] D9600: Add scan-build python implementation

kimgr added a subscriber: kimgr. kimgr added a comment. > > Comment at: tools/scan-build-py/bin/analyze-cc:14 > @@ +13,2 @@ > +from libscanbuild.analyze import wrapper > +sys.exit(wrapper(False)) > > > > It is hard to figure out/search which

Re: [PATCH] D9600: Add scan-build python implementation

dcoughlin added inline comments. Comment at: tools/scan-build-py/libear/ear.c:142 @@ +141,3 @@ +#endif +if (!initialized) +initialized = bear_capture_env_t(_env); rizsotto.mailinglist wrote: > rizsotto.mailinglist wrote: > > to run the full test set >

Re: [PATCH] D9600: Add scan-build python implementation

rizsotto.mailinglist marked 6 inline comments as done. Comment at: tools/scan-build-py/README.md:86 @@ +85,3 @@ +The 2. mode is available only on FreeBSD, Linux and OSX. Where library preload +is available from the dynamic loader. On OSX System Integrity Protection security

Re: [PATCH] D9600: Add scan-build python implementation

dcoughlin added inline comments. Comment at: tools/scan-build-py/README.md:85 @@ +84,3 @@ + +The 2. mode is available only on FreeBSD, Linux and OSX. Where library preload +is available from the dynamic loader. On OSX System Integrity Protection security My

Re: [PATCH] D9600: Add scan-build python implementation

rizsotto.mailinglist marked an inline comment as done. Comment at: tools/scan-build-py/bin/analyze-c++:2 @@ +1,3 @@ +#!/usr/bin/env python +# -*- coding: utf-8 -*- +# The LLVM Compiler Infrastructure zaks.anna wrote: > Where/How is analyze-c++

Re: [PATCH] D9600: Add scan-build python implementation

dcoughlin added inline comments. Comment at: tools/scan-build-py/libear/ear.c:140 @@ +139,3 @@ +#ifdef HAVE_NSGETENVIRON +environ = *_NSGetEnviron(); +#endif The issue I am seeing with library-interposition on OS X seems to be caused by eagerly stashing

Re: [PATCH] D9600: Add scan-build python implementation

zaks.anna added inline comments. Comment at: tools/scan-build-py/README.md:86 @@ +85,3 @@ +The 2. mode is available only on FreeBSD, Linux and OSX. Where library preload +is available from the dynamic loader. On OSX System Integrity Protection security +feature enabled prevents

Re: [PATCH] D9600: Add scan-build python implementation

rizsotto.mailinglist added inline comments. Comment at: tools/scan-build-py/libear/ear.c:141 @@ +140,3 @@ +environ = *_NSGetEnviron(); +#endif +if (!initialized) this call just sets up the `environ` variables for the `bear_capture_env_t` method, two

Re: [PATCH] D9600: Add scan-build python implementation

rizsotto.mailinglist marked 7 inline comments as done. rizsotto.mailinglist added a comment. thanks for the comments. Comment at: tools/scan-build-py/bin/analyze-c++:1 @@ +1,2 @@ +#!/usr/bin/env python +# -*- coding: utf-8 -*- zaks.anna wrote: > What calls this

Re: [PATCH] D9600: Add scan-build python implementation

rizsotto.mailinglist added inline comments. Comment at: tools/scan-build-py/libear/ear.c:282 @@ +281,3 @@ +DLSYM(func, fp, "execve"); + +char const **const menvp = bear_update_environment(envp, _env); okay, since i don't have access for OSX machines can

Re: [PATCH] D9600: Add scan-build python implementation

rizsotto.mailinglist marked an inline comment as done. rizsotto.mailinglist added a comment. > Also, what do you think about renaming intercept-build to "log-build" or some > of the other alternatives I proposed above? I think it is important for the > name of the executable to communicate its

Re: [PATCH] D9600: Add scan-build python implementation

dcoughlin added a comment. In http://reviews.llvm.org/D9600#305980, @rizsotto.mailinglist wrote: > > Also, what do you think about renaming intercept-build to "log-build" or > > some of the other alternatives I proposed above? I think it is important > > for the name of the executable to

Re: [PATCH] D9600: Add scan-build python implementation

zaks.anna added a comment. Hi Laszlo, Here are some comments from me. Should we be worried about the name conflicts (between old scan-build and this tool) during rollout? I think it would be beneficial to rename the tools, but let's discuss the names later. (If we integrate Codecheck, that

Re: [PATCH] D9600: Add scan-build python implementation

zaks.anna added a comment. Hi Laszlo, Comment at: tools/scan-build-py/libear/ear.c:281 @@ +280,3 @@ + +DLSYM(func, fp, "execve"); + This is not the recommended way of interposing on Darwin. All you need to do is provide your function, which can call the

Re: [PATCH] D9600: Add scan-build python implementation

dcoughlin added a comment. Thanks Laszlo. I'm still not convinced that all the python package stuff is needed because scan-build is distributed with clang (see my question inline). Also, what do you think about renaming intercept-build to "log-build" or some of the other alternatives I

Re: [PATCH] D9600: Add scan-build python implementation

dcoughlin added a comment. Thanks Laszlo! Is there a more descriptive name than "intercept-build" (I realize scan-build is pretty general too). It seems to me the point of the intercept-build tool is to generate the compilation database. I think it would be helpful if the tool name indicated

Re: [PATCH] D9600: Add scan-build python implementation

On 11/21/15 9:50 AM, Devin Coughlin wrote: dcoughlin added a comment. Thanks Laszlo! Is there a more descriptive name than "intercept-build" (I realize scan-build is pretty general too). It seems to me the point of the intercept-build tool is to generate the compilation database. I think it

Re: [PATCH] D9600: Add scan-build python implementation

jroelofs added inline comments. Comment at: tools/scan-build-py/libear/__init__.py:1 @@ +1,2 @@ +# -*- coding: utf-8 -*- +# The LLVM Compiler Infrastructure rizsotto.mailinglist wrote: > dcoughlin wrote: > > How does this file fit into the

Re: [PATCH] D9600: Add scan-build python implementation

rizsotto.mailinglist marked 13 inline comments as done. rizsotto.mailinglist added a comment. thanks Devin for your comments. made some changes already (will upload it tonight after some tests). Comment at: tools/scan-build-py/CHANGES.txt:1 @@ +1,1 @@ +v, -- Initial release.

Re: [PATCH] D9600: Add scan-build python implementation

dcoughlin added a comment. Hi Laszlo, thanks for the update! Some high-level questions/comments (and various small things I noticed inline). - I tried running scan-build in interposition mode (i.e., uncommenting out #"$SCRIPT_DIR/analyze-build" $@ in scan-build) and got python compile errors.

Re: [PATCH] D9600: Add scan-build python implementation

jroelofs accepted this revision. jroelofs added a reviewer: jroelofs. jroelofs added a comment. This revision is now accepted and ready to land. Sounds reasonable and I can help with setting up the CMake & LIT goop once you've got it committed. FWIW, I was able to get a simple example

Re: [PATCH] D9600: Add scan-build python implementation

rizsotto.mailinglist added a comment. In http://reviews.llvm.org/D9600#290031, @jroelofs wrote: > Thanks for re-uploading! thanks for your comments! :) most of your comments are about to embed it more into the clang build, test infrastructure. i think these are valid points! i would like to

Re: [PATCH] D9600: Add scan-build python implementation

jroelofs added a comment. Thanks for re-uploading! Comment at: tools/scan-build-py/README.md:39 @@ +38,3 @@ + +$ python setup.py build +$ python setup.py install Mind adding a CMakeLists.txt to drive these from the clang build itself?

Re: [PATCH] D9600: Add scan-build python implementation

rizsotto.mailinglist added a comment. In http://reviews.llvm.org/D9600#287157, @jroelofs wrote: > Would you mind re-uploading this patch as a diff against upstream trunk with > full context? i'm not sure i do understand what do you ask. i wish i could upload these changes as a single patch,

Re: [PATCH] D9600: Add scan-build python implementation

jroelofs added a comment. If you you're familiar with git, I'm asking you to: squash, rebase, and `git diff -U999`, then upload the resulting patch. If you use svn, I'm asking you to: `svn diff -r$(FirstCommit):$(LastCommit) --diff-cmd=diff -x -U999`, and upload that. The reason to squash all

Re: [PATCH] D9600: Add scan-build python implementation

jroelofs added a subscriber: jroelofs. jroelofs added a comment. Would you mind re-uploading this patch as a diff against upstream trunk with full context? http://reviews.llvm.org/D9600 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D9600: Add scan-build python implementation

rizsotto.mailinglist updated this revision to Diff 39703. rizsotto.mailinglist added a comment. findings from compare from older Perl implementation http://reviews.llvm.org/D9600 Files: tools/scan-build-py/README.md tools/scan-build-py/libear/CMakeLists.txt

Re: [PATCH] D9600: Add scan-build python implementation

rizsotto.mailinglist added a comment. the latest update has the following improvements: - makes it work without installation. - pass the `SATestBuild.py` test harness against different projects with `--strictness 2` arguments. (coreutils-8.23, gawk-4.1.1, make-4.0, openssl-1.0.0s, patch-2.7.4,

Re: [PATCH] D9600: Add scan-build python implementation

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a comment. I'm wondering about the status of this, since I've not heard much in the past few months. Is this patch still progressing? (I hope so, I would really love to see us drop our reliance on Perl!)