[PATCH] D96363: Mark output as text if it is really text

abhina.sreeskantharajan added a comment. In D96363#2651116 , @rnk wrote: > In D96363#2650999 , > @abhina.sreeskantharajan wrote: > >> Right, adding a new flag like OF_TextNoCrlf is something I can look into as >>

[PATCH] D96363: Mark output as text if it is really text

rnk added a comment. In D96363#2650999 , @abhina.sreeskantharajan wrote: > Right, adding a new flag like OF_TextNoCrlf is something I can look into as a > solution. However, if Windows is always using binary mode and has no use for > OF_Text flag,

[PATCH] D96363: Mark output as text if it is really text

abhina.sreeskantharajan added a comment. In D96363#2650904 , @rnk wrote: > This is why, in the past, we have taken the direction of opening all files as > binary files. You have probably noticed all of the changes in this direction > that you have to

[PATCH] D96363: Mark output as text if it is really text

rnk added a comment. This is why, in the past, we have taken the direction of opening all files as binary files. You have probably noticed all of the changes in this direction that you have to work around. I think the best solution here would be to add a new `OF_TextNoCrlf` mode that does what

[PATCH] D96363: Mark output as text if it is really text

abhina.sreeskantharajan added a comment. In D96363#2650460 , @aganea wrote: > Hello! This patch breaks compilation when using `-frewrite-includes` on > Windows. It adds an extra line with CRLF, which causes compilation failures > with macros

[PATCH] D96363: Mark output as text if it is really text

aganea added a comment. Hello! This patch breaks compilation when using `-frewrite-includes` on Windows. It adds an extra line with CRLF, which causes compilation failures with macros line-breaks: $ cat -A hello.cpp int foo();^M$ int bar();^M$ #define HELLO \^M$ foo(); \^M$

[PATCH] D96363: Mark output as text if it is really text

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfdb640ea30d4: Mark output as text if it is really text (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D96363: Mark output as text if it is really text

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96363/new/ https://reviews.llvm.org/D96363 ___ cfe-commits mailing list

[PATCH] D96363: Mark output as text if it is really text

abhina.sreeskantharajan updated this revision to Diff 323093. abhina.sreeskantharajan added a comment. Thanks for reviewing! Addressing inline comments by adding /*Binary*/ comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96363/new/

[PATCH] D96363: Mark output as text if it is really text

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with two inline nits. Comment at: clang/lib/Frontend/Rewrite/FrontendActions.cpp:188 std::unique_ptr OS = - CI.createDefaultOutputFile(true,

[PATCH] D96363: Mark output as text if it is really text

abhina.sreeskantharajan updated this revision to Diff 322658. abhina.sreeskantharajan added a comment. Rerun CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96363/new/ https://reviews.llvm.org/D96363 Files: clang/lib/Driver/Driver.cpp

[PATCH] D96363: Mark output as text if it is really text

abhina.sreeskantharajan updated this revision to Diff 322479. abhina.sreeskantharajan added a comment. Remove ARCMigrate change in this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96363/new/ https://reviews.llvm.org/D96363 Files:

[PATCH] D96363: Mark output as text if it is really text

abhina.sreeskantharajan created this revision. Herald added a reviewer: JDevlieghere. abhina.sreeskantharajan requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This is a continuation of https://reviews.llvm.org/D67696. The