[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d64dd8e3c22: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver frontend… (authored by delcypher). Repository: rG LLVM

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

arphaman accepted this revision. arphaman added a comment. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96572/new/ https://reviews.llvm.org/D96572 ___ cfe-commits mailing list

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96572/new/ https://reviews.llvm.org/D96572

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

jansvoboda11 added a comment. > @jansvoboda11 Thanks. If it's okay with you I'll make the change to use the > new marshalling infrastructure in a separate patch > (https://reviews.llvm.org/D97327) because I may need to back port this patch > to an older LLVM branch. That's fine by me.

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

delcypher added a comment. @arphaman @jansvoboda11 ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96572/new/ https://reviews.llvm.org/D96572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

delcypher added a comment. In D96572#2563707 , @jansvoboda11 wrote: > In D96572#2561216 , @delcypher wrote: > >> @jansvoboda11 I noticed that the `Options.td` file is making use of some >> fancy mixins that mean

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

delcypher updated this revision to Diff 325872. delcypher added a comment. Rebase and fix merge conflict caused by f2f59d2a060788f17040ad924ee2d11da0e215c8 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

vitalybuka resigned from this revision. vitalybuka added a comment. LGTM, but leaving for others Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96572/new/ https://reviews.llvm.org/D96572 ___ cfe-commits

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

jansvoboda11 added a comment. In D96572#2561216 , @delcypher wrote: > @jansvoboda11 I noticed that the `Options.td` file is making use of some > fancy mixins that mean the option gets automatically marshalled by the > frontend into the codegen options

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

delcypher added inline comments. Comment at: clang/include/clang/Driver/Options.td:1485 +def sanitize_address_destructor_kind_EQ : Joined<["-"], "fsanitize-address-destructor-kind=">, + MetaVarName<"">, + Flags<[CC1Option]>, vitalybuka wrote: > delcypher

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

delcypher added a comment. @jansvoboda11 I noticed that the `Options.td` file is making use of some fancy mixins that mean the option gets automatically marshalled by the frontend into the codegen options :). I tried this out using the patch to this patch and all my tests seem to pass. Should

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

vitalybuka added inline comments. Comment at: clang/include/clang/Driver/Options.td:1485 +def sanitize_address_destructor_kind_EQ : Joined<["-"], "fsanitize-address-destructor-kind=">, + MetaVarName<"">, + Flags<[CC1Option]>, delcypher wrote: > delcypher

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

delcypher added inline comments. Comment at: clang/include/clang/Driver/Options.td:1485 +def sanitize_address_destructor_kind_EQ : Joined<["-"], "fsanitize-address-destructor-kind=">, + MetaVarName<"">, + Flags<[CC1Option]>, delcypher wrote: > vitalybuka

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

delcypher updated this revision to Diff 323455. delcypher added a comment. Add documentation for `-fsanitize-address-destructor-kind=` option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96572/new/ https://reviews.llvm.org/D96572 Files:

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

delcypher added inline comments. Comment at: clang/include/clang/Driver/Options.td:1485 +def sanitize_address_destructor_kind_EQ : Joined<["-"], "fsanitize-address-destructor-kind=">, + MetaVarName<"">, + Flags<[CC1Option]>, vitalybuka wrote: > What is the

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

delcypher added a comment. Note this patch depends on https://reviews.llvm.org/D96571 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96572/new/ https://reviews.llvm.org/D96572 ___ cfe-commits mailing

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

vitalybuka added inline comments. Comment at: clang/include/clang/Driver/Options.td:1485 +def sanitize_address_destructor_kind_EQ : Joined<["-"], "fsanitize-address-destructor-kind=">, + MetaVarName<"">, + Flags<[CC1Option]>, What is the difference between

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

delcypher updated this revision to Diff 323213. delcypher added a comment. clang-format fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96572/new/ https://reviews.llvm.org/D96572 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

delcypher created this revision. delcypher added reviewers: arphaman, kubamracek, yln, aralisza, kcc, vitalybuka. Herald added subscribers: dexonsmith, dang. Herald added a reviewer: jansvoboda11. delcypher requested review of this revision. Herald added a project: clang. Herald added a