[PATCH] D96803: EntryExitInstrumenter: Move to a module pass and enable at all optimization levels (PR49143)

2021-02-18 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added a comment. In D96803#2571316 , @zatrazz wrote: > In D96803#2569436 , @aeubanks wrote: > >> In D96803#2568179 , @zatrazz wrote: >> >>> In D96803#2566322

[PATCH] D96803: EntryExitInstrumenter: Move to a module pass and enable at all optimization levels (PR49143)

2021-02-18 Thread Adhemerval Zanella via Phabricator via cfe-commits
zatrazz added a comment. In D96803#2569436 , @aeubanks wrote: > In D96803#2568179 , @zatrazz wrote: > >> In D96803#2566322 , @aeubanks wrote: >> >>> why is this now a module

[PATCH] D96803: EntryExitInstrumenter: Move to a module pass and enable at all optimization levels (PR49143)

2021-02-17 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added a comment. In D96803#2568179 , @zatrazz wrote: > In D96803#2566322 , @aeubanks wrote: > >> why is this now a module pass? > > Mainly to avoid the default rule from new pass manager to *not* apply any

[PATCH] D96803: EntryExitInstrumenter: Move to a module pass and enable at all optimization levels (PR49143)

2021-02-17 Thread Adhemerval Zanella via Phabricator via cfe-commits
zatrazz added a comment. In D96803#2566322 , @aeubanks wrote: > why is this now a module pass? Mainly to avoid the default rule from new pass manager to *not* apply any FunctionPass for optnone (which is the main issue for PR49143). Is there a better

[PATCH] D96803: EntryExitInstrumenter: Move to a module pass and enable at all optimization levels (PR49143)

2021-02-16 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added a comment. why is this now a module pass? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96803/new/ https://reviews.llvm.org/D96803 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D96803: EntryExitInstrumenter: Move to a module pass and enable at all optimization levels (PR49143)

2021-02-16 Thread Adhemerval Zanella via Phabricator via cfe-commits
zatrazz created this revision. zatrazz added reviewers: lenary, ostannard, aeubanks. Herald added a subscriber: hiraditya. zatrazz requested review of this revision. Herald added projects: clang, LLVM. The function passes are disabled by default for optnone with the new pass manager. The pass is