[PATCH] D97132: [clang-tidy] Harden PreferMemberInitializerCheck

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2e15fa532f3: [clang-tidy] Harden PreferMemberInitializerCheck (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97132/new/

[PATCH] D97132: [clang-tidy] Harden PreferMemberInitializerCheck

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97132/new/ https://reviews.llvm.org/D97132

[PATCH] D97132: [clang-tidy] Harden PreferMemberInitializerCheck

njames93 updated this revision to Diff 325484. njames93 marked 2 inline comments as done. njames93 added a comment. Address `auto` comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97132/new/ https://reviews.llvm.org/D97132 Files:

[PATCH] D97132: [clang-tidy] Harden PreferMemberInitializerCheck

njames93 updated this revision to Diff 325482. njames93 added a comment. Add a test for the crash fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97132/new/ https://reviews.llvm.org/D97132 Files:

[PATCH] D97132: [clang-tidy] Harden PreferMemberInitializerCheck

njames93 added a comment. In D97132#2578992 , @aaron.ballman wrote: >> Fix potential crash if macros are used, Now we just don't try to emit a fix. > > Can you add a test case that covers this change? I can try, but I'm not sure of the exact cause of

[PATCH] D97132: [clang-tidy] Harden PreferMemberInitializerCheck

aaron.ballman added a comment. > Fix potential crash if macros are used, Now we just don't try to emit a fix. Can you add a test case that covers this change? Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp:105 + return

[PATCH] D97132: [clang-tidy] Harden PreferMemberInitializerCheck

njames93 updated this revision to Diff 325428. njames93 added a comment. Fix potential crash if macros are used, Now we just don't try to emit a fix. Fix issue where FixIt for member initializers would be inserted at the start of the constructor decl due to implicit member initializers confusing

[PATCH] D97132: [clang-tidy] Harden PreferMemberInitializerCheck

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, baloghadamsoftware, gribozavr2. Herald added subscribers: rnkovacs, kbarton, xazax.hun, nemanjai. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.