[PATCH] D97137: Bug fix of clang-format, the AlignConsecutiveDeclarations option doesn't handle pointer properly

HazardyKnusperkeks added a comment. In D97137#2584417 , @darwin wrote: > Hi guys, thanks for accepting the change. But I don't have commit access of > LLVM. Can someone commit it for me? Can and will do. Need the name and email for the commit. But I

[PATCH] D97137: Bug fix of clang-format, the AlignConsecutiveDeclarations option doesn't handle pointer properly

darwin added a comment. Hi guys, thanks for accepting the change. But I don't have have commit access of LLVM. Can someone commit it for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97137/new/ https://reviews.llvm.org/D97137

[PATCH] D97137: Bug fix of clang-format, the AlignConsecutiveDeclarations option doesn't handle pointer properly

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. In D97137#2580664 , @darwin wrote: > In D97137#2579669 , > @HazardyKnusperkeks wrote:

[PATCH] D97137: Bug fix of clang-format, the AlignConsecutiveDeclarations option doesn't handle pointer properly

darwin updated this revision to Diff 325766. darwin marked 3 inline comments as done. darwin added a comment. Fix the code's alignment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97137/new/ https://reviews.llvm.org/D97137 Files:

[PATCH] D97137: Bug fix of clang-format, the AlignConsecutiveDeclarations option doesn't handle pointer properly

darwin added a comment. In D97137#2579669 , @HazardyKnusperkeks wrote: > You should mark comments as done, if they are. > > Does your modification maybe add something to the alignment which is not a > declaration? > > int a; > double b; > a * b; >

[PATCH] D97137: Bug fix of clang-format, the AlignConsecutiveDeclarations option doesn't handle pointer properly

HazardyKnusperkeks added a comment. You should mark comments as done, if they are. Does your modification maybe add something to the alignment which is not a declaration? int a; double b; a * b; How is that formatted? Yeah unlikely that something like that is in code, but it could be

[PATCH] D97137: Bug fix of clang-format, the AlignConsecutiveDeclarations option doesn't handle pointer properly

darwin updated this revision to Diff 325455. darwin added a comment. Add more test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97137/new/ https://reviews.llvm.org/D97137 Files: clang/lib/Format/WhitespaceManager.cpp

[PATCH] D97137: Bug fix of clang-format, the AlignConsecutiveDeclarations option doesn't handle pointer properly

darwin added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:716-717 break; if (Next->isOneOf(TT_StartOfName, TT_FunctionDeclarationName, tok::kw_operator)) return false; Maybe