[PATCH] D97251: [llvm] Add assertions for the smart pointers with the possibility to be null in ClangAttrEmitter

aaron.ballman added a comment. In D97251#2583843 , @OikawaKirie wrote: > @aaron.ballman > > My only concern is the recursive call to this function on line 1359. If you > think it is also OK for the recursive call on line 1359, I will update the > patch

[PATCH] D97251: [llvm] Add assertions for the smart pointers with the possibility to be null in ClangAttrEmitter

OikawaKirie requested review of this revision. OikawaKirie added a comment. @aaron.ballman My only concern is the recursive call to this function on line 1359. If you think it is also OK for the recursive call on line 1359, I will update the patch as you mentioned above. BTW, how can I test

[PATCH] D97251: [llvm] Add assertions for the smart pointers with the possibility to be null in ClangAttrEmitter

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a few minor changes to be made. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:1364 + assert(Ptr && "Cannot create argument."); +

[PATCH] D97251: [llvm] Add assertions for the smart pointers with the possibility to be null in ClangAttrEmitter

OikawaKirie added a comment. As a recursive function it is, the original patch in D91844 was adding assertions where the function is called other places in the file. To confirm it will not lead to a crash here, I re-build my code base with clang and

[PATCH] D97251: [llvm] Add assertions for the smart pointers with the possibility to be null in ClangAttrEmitter

OikawaKirie created this revision. OikawaKirie added reviewers: dexonsmith, aaron.ballman, pcc. OikawaKirie added a project: clang. OikawaKirie requested review of this revision. Herald added a subscriber: cfe-commits. Split from D91844 . The return value of