[PATCH] D97513: Add ConfigVersion.cmake files

steveire added inline comments. Comment at: flang/cmake/modules/CMakeLists.txt:15 # Generate FlangConfig.cmake for the build tree. +include(CMakePackageConfigHelpers) + Instead of including this multiple times, please add it to `AddLLVM.cmake`. That file is use

[PATCH] D97513: Add ConfigVersion.cmake files

alexreinking updated this revision to Diff 333688. alexreinking added a comment. Update & wrap commit message CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97513/new/ https://reviews.llvm.org/D97513 Files: clang/cmake/modules/CMakeLists.txt flang/cmake/modules/CMakeLists.txt lld/

[PATCH] D97513: Add ConfigVersion.cmake files

alexreinking updated this revision to Diff 333687. alexreinking added a comment. Remove unused version variables (that were used in a previous revision) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97513/new/ https://reviews.llvm.org/D97513 Files: clang/cmake/modules/CMakeLists.txt

[PATCH] D97513: Add ConfigVersion.cmake files

alexreinking updated this revision to Diff 333683. alexreinking added a comment. Drop *ConfigVersion.cmake files from `CMakeFiles` tree CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97513/new/ https://reviews.llvm.org/D97513 Files: clang/cmake/modules/CMakeLists.txt flang/cmake/mod

[PATCH] D97513: Add ConfigVersion.cmake files

alexreinking updated this revision to Diff 333677. alexreinking added a comment. Use PACKAGE_VERSION instead CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97513/new/ https://reviews.llvm.org/D97513 Files: clang/cmake/modules/CMakeLists.txt flang/cmake/modules/CMakeLists.txt lld/C

[PATCH] D97513: Add ConfigVersion.cmake files

alexreinking updated this revision to Diff 333657. alexreinking added a comment. Uses write_basic_package_version_file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97513/new/ https://reviews.llvm.org/D97513 Files: clang/cmake/modules/CMakeLists.txt flang/cmake/modules/CMakeLists.t

[PATCH] D97513: Add ConfigVersion.cmake files

steveire added inline comments. Comment at: lld/cmake/modules/LLDConfigVersion.cmake.in:1 +set(PACKAGE_VERSION "@PACKAGE_VERSION@") + steveire wrote: > Did you consider using `write_basic_package_version_file` instead of adding > these files? Ah, sorry, I see yo

[PATCH] D97513: Add ConfigVersion.cmake files

steveire added inline comments. Herald added a subscriber: dcaballe. Comment at: lld/cmake/modules/LLDConfigVersion.cmake.in:1 +set(PACKAGE_VERSION "@PACKAGE_VERSION@") + Did you consider using `write_basic_package_version_file` instead of adding these files?

[PATCH] D97513: Add ConfigVersion.cmake files

alexreinking added a comment. So with this patch, I tried to imitate the existing code as much as possible. However, I think it would be quite a bit better to use the `write_basic_package_version_file` command from `CMakePackageConfigHelpers`. It gained support for major + minor version compati

[PATCH] D97513: Add ConfigVersion.cmake files

alexreinking created this revision. alexreinking added reviewers: chandlerc, gottesmm, pmccormick. Herald added subscribers: cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle,