[PATCH] D97573: [OpenMP] Handle non-function context before checking for diagnostic emission

This revision was automatically updated to reflect the committed changes. Closed by commit rGc2de5aff1a08: [OpenMP] Handle non-function context before checking for diagnostic (authored by pmrao, committed by erichkeane). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97573: [OpenMP] Handle non-function context before checking for diagnostic emission

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97573/new/ https://reviews.llvm.org/D97573 ___

[PATCH] D97573: [OpenMP] Handle non-function context before checking for diagnostic emission

jdoerfert added a comment. looks reasonable to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97573/new/ https://reviews.llvm.org/D97573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D97573: [OpenMP] Handle non-function context before checking for diagnostic emission

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1946 +FunctionEmissionStatus FES = getEmissionStatus(FD); +switch (FES) { +case FunctionEmissionStatus::Emitted: pmrao wrote: > erichkeane wrote: > > pmrao wrote: > > >

[PATCH] D97573: [OpenMP] Handle non-function context before checking for diagnostic emission

pmrao marked an inline comment as not done. pmrao added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1946 +FunctionEmissionStatus FES = getEmissionStatus(FD); +switch (FES) { +case FunctionEmissionStatus::Emitted: erichkeane wrote: >

[PATCH] D97573: [OpenMP] Handle non-function context before checking for diagnostic emission

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1946 +FunctionEmissionStatus FES = getEmissionStatus(FD); +switch (FES) { +case FunctionEmissionStatus::Emitted: pmrao wrote: > erichkeane wrote: > > Tabs here instead of

[PATCH] D97573: [OpenMP] Handle non-function context before checking for diagnostic emission

pmrao added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1946 +FunctionEmissionStatus FES = getEmissionStatus(FD); +switch (FES) { +case FunctionEmissionStatus::Emitted: erichkeane wrote: > Tabs here instead of spaces. > > I think this

[PATCH] D97573: [OpenMP] Handle non-function context before checking for diagnostic emission

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1946 +FunctionEmissionStatus FES = getEmissionStatus(FD); +switch (FES) { +case FunctionEmissionStatus::Emitted: Tabs here instead of spaces. I think this is the right fix

[PATCH] D97573: [OpenMP] Handle non-function context before checking for diagnostic emission

pmrao created this revision. pmrao added reviewers: ABataev, bader, erichkeane, jdoerfert. Herald added subscribers: guansong, yaxunl. pmrao requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Ensure that we are in a function declaration context