[PATCH] D97717: [SYCL] Rework the SYCL driver options

aaron.ballman closed this revision. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. In D97717#2631515 , @jansvoboda11 wrote: > Thanks for addressing this! LGTM Thank you for the review! I've commit in

[PATCH] D97717: [SYCL] Rework the SYCL driver options

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. Thanks for addressing this! LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97717/new/ https://reviews.llvm.org/D97717 ___

[PATCH] D97717: [SYCL] Rework the SYCL driver options

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: clang/unittests/Frontend/CompilerInvocationTest.cpp:547 TEST_F(CommandLineTest, ConditionalParsingIfTrueFlagNotPresent) { const char *Args[] = {"-fsycl"};

[PATCH] D97717: [SYCL] Rework the SYCL driver options

aaron.ballman updated this revision to Diff 331227. aaron.ballman marked 3 inline comments as done. aaron.ballman added a comment. Updating the unit tests based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97717/new/ https://reviews.llvm.org/D97717 Files:

[PATCH] D97717: [SYCL] Rework the SYCL driver options

jansvoboda11 added inline comments. Comment at: clang/unittests/Frontend/CompilerInvocationTest.cpp:547 TEST_F(CommandLineTest, ConditionalParsingIfTrueFlagNotPresent) { const char *Args[] = {"-fsycl"}; This test originally checked that enabling SYCL

[PATCH] D97717: [SYCL] Rework the SYCL driver options

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: clang/unittests/Frontend/CompilerInvocationTest.cpp:547 + // there is no syntax I could find that would allow it). However, the option + // is handled properly on a real

[PATCH] D97717: [SYCL] Rework the SYCL driver options

aaron.ballman updated this revision to Diff 330786. aaron.ballman added a comment. Update based on review feedback to gate use of -sycl-std on use of -fsycl-is-device or -fsycl-is-host. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97717/new/ https://reviews.llvm.org/D97717 Files:

[PATCH] D97717: [SYCL] Rework the SYCL driver options

jansvoboda11 requested changes to this revision. jansvoboda11 added a comment. This revision now requires changes to proceed. I like the simplification of the command line interface. I have concerns about changing the tests just to make them pass though. Comment at:

[PATCH] D97717: [SYCL] Rework the SYCL driver options

aaron.ballman added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97717/new/ https://reviews.llvm.org/D97717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D97717: [SYCL] Rework the SYCL driver options

aaron.ballman updated this revision to Diff 327769. aaron.ballman added a comment. Fixed the failing unit tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97717/new/ https://reviews.llvm.org/D97717 Files: clang/include/clang/Basic/LangOptions.def

[PATCH] D97717: [SYCL] Rework the SYCL driver options

aaron.ballman added a comment. In D97717#2599728 , @bader wrote: > @aaron.ballman, it looks like unittests should be updated as well. Please, > take a look at failures in pre-merge checks. Thanks, I'll correct those! Comment at:

[PATCH] D97717: [SYCL] Rework the SYCL driver options

bader added a comment. @aaron.ballman, it looks like unittests should be updated as well. Please, take a look at failures in pre-merge checks. Comment at: clang/include/clang/Basic/LangOptions.def:252 LANGOPT(SYCLIsDevice , 1, 0, "Generate code for SYCL device")

[PATCH] D97717: [SYCL] Rework the SYCL driver options

aaron.ballman updated this revision to Diff 327412. aaron.ballman added a comment. Rebased and added a Frontend-specific test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97717/new/ https://reviews.llvm.org/D97717 Files: clang/include/clang/Basic/LangOptions.def

[PATCH] D97717: [SYCL] Rework the SYCL driver options

aaron.ballman created this revision. aaron.ballman added reviewers: erichkeane, bader. Herald added subscribers: jansvoboda11, dexonsmith, dang, Anastasia, ebevhan, yaxunl. aaron.ballman requested review of this revision. Herald added a project: clang. SYCL compilations initiated by the driver