[PATCH] D97743: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

MaskRay added a comment. There are some side effects: because -D is passed as command line options, it has `` in its filename, so `isWrittenInBuiltinFile` will not match it (`isWrittenInBuiltinFile` can match other built-in macros)... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D97743: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

jansvoboda11 added a comment. In D97743#2614899 , @MaskRay wrote: > Move to driver Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97743/new/ https://reviews.llvm.org/D97743

[PATCH] D97743: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9d117e7b2a39: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D97743: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

MaskRay updated this revision to Diff 329441. MaskRay added a comment. Move to driver Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97743/new/ https://reviews.llvm.org/D97743 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D97743: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

jansvoboda11 added a comment. In D97743#2614480 , @MaskRay wrote: > In D97743#2613629 , @jansvoboda11 > wrote: > >> Could the logic be implemented in the driver? >> >> LGTM regardless. > > No. `Res` is a

[PATCH] D97743: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

MaskRay added a comment. In D97743#2614827 , @thakis wrote: > Still broken: http://45.33.8.238/linux/41278/step_7.txt b4948c27d2e40586c0c4fa7cbf20b9c40a9f7584 The green Harbomaster

[PATCH] D97743: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

thakis added a comment. Still broken: http://45.33.8.238/linux/41278/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97743/new/ https://reviews.llvm.org/D97743 ___ cfe-commits mailing list

[PATCH] D97743: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

MaskRay added a comment. In D97743#2614792 , @thakis wrote: > This seems to break tests everywhere: > http://45.33.8.238/linux/41275/step_7.txt My bad. Fixed by df67d3526962ae51446b1390e7c40e045e580ec2

[PATCH] D97743: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

thakis added a comment. This seems to break tests everywhere: http://45.33.8.238/linux/41275/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97743/new/ https://reviews.llvm.org/D97743 ___

[PATCH] D97743: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc11ff4bbada3: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D97743: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

MaskRay added a comment. In D97743#2613629 , @jansvoboda11 wrote: > Could the logic be implemented in the driver? > > LGTM regardless. No. `Res` is a `clang::CompilerInvocation` object. `CompilerInvocation` is not in the driver... Repository: rG

[PATCH] D97743: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. Could the logic be implemented in the driver? LGTM regardless. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97743/new/

[PATCH] D97743: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

MaskRay added a comment. @jansvoboda11 :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97743/new/ https://reviews.llvm.org/D97743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D97743: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

MaskRay updated this revision to Diff 327320. MaskRay retitled this revision from "Define __GCC_HAVE_DWARF2_CFI_ASM to 1 on ELF/Mach-O if CC1 -munwind-tables is specified" to "Define __GCC_HAVE_DWARF2_CFI_ASM if applicable". MaskRay edited the summary of this revision. MaskRay added a comment.