This revision was automatically updated to reflect the committed changes.
eandrews marked an inline comment as done.
Closed by commit rGd8b8f544d9de: [Reland] "Do not apply calling
conventions to MSVC entry points" (authored by eandrews).
Herald added a project: clang.
Repository:
rG LLVM Githu
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm, thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97941/new/
https://reviews.llvm.org/D97941
___
cfe-commits mailing list
cfe-commits@
eandrews added inline comments.
Comment at: clang/lib/Sema/SemaDecl.cpp:11206-11207
+} else if (FT->getCallConv() != CC_X86StdCall) {
+ // Default calling convention for WinMain, wWinMain and DllMain is
+ // __stdcall
+ FT = Context.adjustFunctionType(
eandrews updated this revision to Diff 329099.
eandrews edited the summary of this revision.
eandrews added a comment.
Implemented review comment to restrict __stdcall default calling convention
(for WinMain, wWinMain, and DllMain) to 32 bit Windows.
CHANGES SINCE LAST ACTION
https://reviews
rnk added a comment.
Seems reasonable
Comment at: clang/lib/Sema/SemaDecl.cpp:11206-11207
+} else if (FT->getCallConv() != CC_X86StdCall) {
+ // Default calling convention for WinMain, wWinMain and DllMain is
+ // __stdcall
+ FT = Context.adjustFunctionType(
eandrews created this revision.
eandrews added reviewers: rnk, akhuang, dmajor.
Herald added a subscriber: mstorsjo.
eandrews requested review of this revision.
This patch is a second attempt at fixing a link error for MSVC entry points
when calling conventions are specified using a flag.
Callin
