[PATCH] D98110: [NFC][clangd] Use table to collect option aliases

2022-02-09 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:478 + HELP, METAVAR, VALUES) \ + {DriverID::OPT_##ID, DriverID::OPT_##ALIAS, (void *)ALIASARGS}, +#include "clang/Driver/Options.inc"

[PATCH] D98110: [NFC][clangd] Use table to collect option aliases

2022-02-09 Thread Mikael Holmén via Phabricator via cfe-commits
uabelho added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:478 + HELP, METAVAR, VALUES) \ + {DriverID::OPT_##ID, DriverID::OPT_##ALIAS, (void *)ALIASARGS}, +#include "clang/Driver/Options.inc"

[PATCH] D98110: [NFC][clangd] Use table to collect option aliases

2022-01-24 Thread Yuanfang Chen via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3b64ab574d98: [NFC][clangd] Use table to collect option aliases (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98110/new/

[PATCH] D98110: [NFC][clangd] Use table to collect option aliases

2022-01-24 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98110/new/ https://reviews.llvm.org/D98110

[PATCH] D98110: [NFC][clangd] Use table to collect option aliases

2021-03-16 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen added a comment. Herald added a project: clang-tools-extra. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98110/new/ https://reviews.llvm.org/D98110 ___ cfe-commits mailing list

[PATCH] D98110: [NFC][clangd] Use table to collect option aliases

2021-03-06 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen created this revision. ychen added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. ychen requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. - Suppress a lot of