[PATCH] D98450: [clang] store an identifer instead of declref for ns_error_domain attribute

aaron.ballman added a comment. In D98450#2699970 , @arphaman wrote: > Your argument makes sense. The problem right now is that clang doesn't allow > the name to be used even when the user marks up availability correctly trying > to guard the use of the

[PATCH] D98450: [clang] store an identifer instead of declref for ns_error_domain attribute

arphaman added a comment. In D98450#2699970 , @arphaman wrote: > Sorry, getting back to this only now. > > In D98450#2621907 , @aaron.ballman > wrote: > >> In D98450#2621877

[PATCH] D98450: [clang] store an identifer instead of declref for ns_error_domain attribute

arphaman added a comment. Sorry, getting back to this only now. In D98450#2621907 , @aaron.ballman wrote: > In D98450#2621877 , @MForster wrote: > >> That's ok for me. I'd suggest to wait for Aaron's feedback,

[PATCH] D98450: [clang] store an identifer instead of declref for ns_error_domain attribute

aaron.ballman added a comment. In D98450#2621877 , @MForster wrote: > That's ok for me. I'd suggest to wait for Aaron's feedback, because IIRC it > was his suggestion in the first place to go to declref. I have the same concerns with this patch as I did

[PATCH] D98450: [clang] store an identifer instead of declref for ns_error_domain attribute

MForster added a comment. That's ok for me. I'd suggest to wait for Aaron's feedback, because IIRC it was his suggestion in the first place to go to declref. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98450/new/ https://reviews.llvm.org/D98450

[PATCH] D98450: [clang] store an identifer instead of declref for ns_error_domain attribute

arphaman added a comment. The original implementation of the attribute on GitHub.com/apple/llvm-project also used the identifier instead of the declref, so we would like to go back to that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98450/new/ https://reviews.llvm.org/D98450

[PATCH] D98450: [clang] store an identifer instead of declref for ns_error_domain attribute

arphaman created this revision. arphaman added reviewers: steven_wu, MForster. Herald added subscribers: ributzka, jkorous. Herald added a reviewer: aaron.ballman. arphaman requested review of this revision. The attribute with declref is incompatible with Apple's SDKs, as the declref at the point