[PATCH] D98539: [OpenCL] Set target as spir for c-index-test for OpenCL

2021-03-15 Thread Anton Zabaznov via Phabricator via cfe-commits
azabaznov added a comment. @Anastasia, thanks for landing this! Sorry for delay, I though that this can wait until Monday Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98539/new/ https://reviews.llvm.org/D98539

[PATCH] D98539: [OpenCL] Set target as spir for c-index-test for OpenCL

2021-03-12 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. In D98539#2623038 , @thakis wrote: > Can we get this landed asap please? Done! Sorry for the noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98539/new/

[PATCH] D98539: [OpenCL] Set target as spir for c-index-test for OpenCL

2021-03-12 Thread Anastasia Stulova via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeed88e91f331: [OpenCL] Use spir target for CIndex tests for OpenCL. (authored by Anastasia). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D98539: [OpenCL] Set target as spir for c-index-test for OpenCL

2021-03-12 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Can we get this landed asap please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98539/new/ https://reviews.llvm.org/D98539 ___ cfe-commits mailing list

[PATCH] D98539: [OpenCL] Set target as spir for c-index-test for OpenCL

2021-03-12 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! I can't see why we would need to tests anything target-specific here anyway, so I think the change is reasonable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98539: [OpenCL] Set target as spir for c-index-test for OpenCL

2021-03-12 Thread Anton Zabaznov via Phabricator via cfe-commits
azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh, thakis. Herald added subscribers: arphaman, yaxunl. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Otherwise (for other targets) testing may be