This revision was automatically updated to reflect the committed changes.
Closed by commit rG48ab9674b21b: [ASTMatchers][NFC] Use move semantics when
passing matchers around. (authored by njames93).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
njames93 updated this revision to Diff 331353.
njames93 added a comment.
Fix formatting
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98792/new/
https://reviews.llvm.org/D98792
Files:
clang/include/clang/ASTMatchers/ASTMatchersInternal.h
njames93 added inline comments.
Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:1564
public:
- PolymorphicMatcher(const ParamTypes &... Params) : Params(Params...) {}
+ PolymorphicMatcher(const ParamTypes &...Params) : Params(Params...) {}
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from a small nit.
Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:1564
public:
- PolymorphicMatcher(const ParamTypes &...
njames93 updated this revision to Diff 331340.
njames93 added a comment.
Fix PP guards erroneously using #ifdef
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98792/new/
https://reviews.llvm.org/D98792
Files:
njames93 created this revision.
njames93 added reviewers: klimek, aaron.ballman, steveire.
Herald added a subscriber: pengfei.
njames93 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Changing matchers to use non-const members and adding
