This revision was automatically updated to reflect the committed changes.
Closed by commit rGb8baa2a91324: [ARM][AArch64] Require appropriate features
for crypto algorithms (authored by dcandler).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
dcandler added inline comments.
Comment at: clang/lib/Basic/Targets/AArch64.h:36
+ bool HasSHA3;
+ bool HasSM4;
bool HasUnaligned;
rsanthir.quic wrote:
> Would it make sense to further differentiate SM3 and SM4? I see that we
> differentiate between the
lenary accepted this revision.
lenary added a comment.
This revision is now accepted and ready to land.
LGTM. Please give the other reviewers time to chime in about this patch before
merging.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99079/new/
https://reviews.llvm.org/D99079
dcandler updated this revision to Diff 338126.
dcandler marked 2 inline comments as done.
dcandler added a comment.
Removed one duplicated line.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99079/new/
https://reviews.llvm.org/D99079
Files:
clang/include/clang/Basic/arm_neon.td
dcandler updated this revision to Diff 338046.
dcandler added a comment.
I've updated the patch to fix the test failures, and slightly reworked the
driver code to avoid the above iterator invalidation. I've also added a comment
there to clarify what it is doing: individually determining whether
rsanthir.quic added inline comments.
Comment at: clang/lib/Basic/Targets/AArch64.h:36
+ bool HasSHA3;
+ bool HasSM4;
bool HasUnaligned;
Would it make sense to further differentiate SM3 and SM4? I see that we
differentiate between the two in arm_neon.td
t.p.northover added inline comments.
Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:641
+ });
+ if ((ItSHA2 != Features.rend()) || (ItSHA2 != Features.rend()))
+Features.push_back("-crypto");
Both of these checks are identical.
And could we get
dcandler created this revision.
dcandler added reviewers: t.p.northover, rsanthir.quic, SjoerdMeijer, efriedma,
peter.smith, labrinea.
Herald added subscribers: danielkiss, hiraditya, kristof.beyls.
dcandler requested review of this revision.
Herald added projects: clang, LLVM.
Herald added
