This revision was automatically updated to reflect the committed changes.
Xiangling_L marked an inline comment as done.
Closed by commit rGd5085617986e: [AIX] Support init priority attribute
(authored by Xiangling_L).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
Xiangling_L marked an inline comment as done.
Xiangling_L added inline comments.
Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:663
+ // Create our global prioritized cleanup function.
+ if (!PrioritizedCXXStermFinalizers.empty()) {
jasonliu wrote:
> Just
jasonliu accepted this revision.
jasonliu added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:663
+ // Create our global prioritized cleanup function.
+ if (!PrioritizedCXXStermFinalizers.empty()) {
Xiangling_L updated this revision to Diff 58.
Xiangling_L marked an inline comment as done.
Xiangling_L added a comment.
Add assertion to make sure we have correct priority value in range;
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99291/new/
https://reviews.llvm.org/D99291
aaron.ballman added inline comments.
Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:574
+ std::string PrioritySuffix = llvm::utostr(Priority);
+ // Priority is always <= 65535 (enforced by sema).
+ PrioritySuffix = std::string(6 - PrioritySuffix.size(), '0') +
PrioritySuffix;
Xiangling_L created this revision.
Xiangling_L added reviewers: jasonliu, hubert.reinterpretcast, ZarkoCA, xingxue.
Herald added a reviewer: aaron.ballman.
Xiangling_L requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM
