shafik added a comment.
Herald added a project: All.
This is accepted but it looks like we need the previous `void{}` fix in order
to land this. It would be nice to get both in before phab is not usable anymore.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
aaronpuchert updated this revision to Diff 387056.
aaronpuchert marked an inline comment as done.
aaronpuchert added a comment.
Also fix code generation for `void{}`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99466/new/
aaronpuchert added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:466-469
+// [expr.type.conv]: if the type is cv void and the initializer is () or
{},
+// the expression is a prvalue of type void that performs no
initialization.
+QualType T =
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:466-469
+// [expr.type.conv]: if the type is cv void and the initializer is () or
{},
+// the expression is a
aaronpuchert updated this revision to Diff 333719.
aaronpuchert added a comment.
Replace `E->getType()` argument by `T`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99466/new/
https://reviews.llvm.org/D99466
Files:
aaronpuchert created this revision.
aaronpuchert added a reviewer: rsmith.
aaronpuchert requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
We treat the expression void() as CXXScalarValueInitExpr for historic
reasons probably, but void isn't
