pengfei added inline comments.
Comment at: llvm/docs/LangRef.rst:21195
+'``llvm.arithmetic_fence``' Intrinsic
+^^
+
pengfei wrote:
> Should be equal to the text?
Yeah, a good catch. But I initially meant `^^^` should be equal to the
mibintc updated this revision to Diff 350700.
mibintc added a comment.
I corrected error in LangRef documentation that @pengfei pointed out.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99675/new/
https://reviews.llvm.org/D99675
Files:
pengfei added inline comments.
Comment at: llvm/docs/LangRef.rst:21195
+'``llvm.arithmetic_fence``' Intrinsic
+^^
+
Should be equal to the text?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
mibintc updated this revision to Diff 350307.
mibintc added a comment.
This patch addresses all of @craig.topper comments and adds documentation for
the new intrinsic to the language reference as requested by @LuoYuanke nke
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
craig.topper added inline comments.
Comment at: llvm/include/llvm/IR/IRBuilder.h:903
+ const Twine = "") {
+return CreateIntrinsic(Intrinsic::arithmetic_fence, {DstType}, {Val},
nullptr,
+ Name);
LuoYuanke added a comment.
We may add description on the intrinsic in docs/LangRef.rst.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99675/new/
https://reviews.llvm.org/D99675
___
cfe-commits mailing
mibintc updated this revision to Diff 348046.
mibintc retitled this revision from "RFC [llvm][clang] Create new intrinsic
llvm.arith.fence to control FP optimization at expression level" to
"[llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization
at expression level".