[PATCH] D99755: Remove clang/runtime and `COMPILER_RT_INSTALL_PATH`

Ericson2314 updated this revision to Diff 335154. Ericson2314 added a comment. Put on top of D99860 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99755/new/ https://reviews.llvm.org/D99755 Files:

[PATCH] D99755: Remove clang/runtime and `COMPILER_RT_INSTALL_PATH`

Ericson2314 added a comment. See also D99860 . We may still want to remove `clang/runtime`, but I don't think it's necessary. I will turn this revision into one on top of that just for for removing `clang/runtime`. Repository: rG LLVM Github Monorepo

[PATCH] D99755: Remove clang/runtime and `COMPILER_RT_INSTALL_PATH`

Ericson2314 updated this revision to Diff 335149. Ericson2314 added a comment. Remove stray `COMPILER_RT_INSTALL_PATH` I am uncertain about is the redefining of `CMAKE_INSTALL_PREIX` in `compiler-rt/cmake/base-config-ix.cmake`. This occurs under `LLVM_TREE_AVAILABLE`. If this is just for

[PATCH] D99755: Remove clang/runtime and `COMPILER_RT_INSTALL_PATH`

Ericson2314 added a comment. So unfortunately it seems the `clang/runtime`'s use was triggered by `LLVM_BUILD_EXTERNAL_COMPILER_RT`, which is in use in a few places still? (And not just Apple ones.) On the other hand, since this is doing an *external* CMake for compiler-rt, I fail to see why

[PATCH] D99755: Remove clang/runtime and `COMPILER_RT_INSTALL_PATH`

Ericson2314 updated this revision to Diff 334955. Ericson2314 added a comment. Remove add_subdirectory(runtime) for deleted dir Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99755/new/ https://reviews.llvm.org/D99755 Files: clang/CMakeLists.txt

[PATCH] D99755: Remove clang/runtime and `COMPILER_RT_INSTALL_PATH`

phosek added a comment. @beanz do you know if `clang/runtime` is still being used? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99755/new/ https://reviews.llvm.org/D99755 ___ cfe-commits mailing list

[PATCH] D99755: Remove clang/runtime and `COMPILER_RT_INSTALL_PATH`

Ericson2314 updated this revision to Diff 334780. Ericson2314 added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Also remove `clang/runtime` from a TODO comment elsewhere in the tree I put `runtimes` in there as it's evidentially its spiritual successor.

[PATCH] D99755: Remove clang/runtime and `COMPILER_RT_INSTALL_PATH`

Ericson2314 added inline comments. Comment at: compiler-rt/cmake/base-config-ix.cmake:95 set(COMPILER_RT_LIBRARY_INSTALL_DIR -${COMPILER_RT_INSTALL_PATH}) +"") else(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR) I'm a bit confused we'd ever want too install

[PATCH] D99755: Remove clang/runtime and `COMPILER_RT_INSTALL_PATH`

Ericson2314 created this revision. Herald added a subscriber: mgorny. Ericson2314 requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. This patch removes those in order to simplify things for D99484