phosek accepted this revision.
phosek added a comment.
LGTM
Comment at: llvm/lib/InterfaceStub/IFSStub.cpp:70
+ }
+ llvm_unreachable("unknown bitwidth");
+}
This shouldn't be needed.
Comment at: llvm/lib/InterfaceStub/IFSStub.cpp:82
+ }
+
haowei marked an inline comment as done.
haowei added inline comments.
Comment at: llvm/include/llvm/InterfaceStub/ELFObjHandler.h:25
namespace elfabi {
phosek wrote:
> Shouldn't this be in namespace `ifs`?
This was renamed to ifs in D100139. Rename it here
phosek accepted this revision.
phosek added inline comments.
This revision is now accepted and ready to land.
Comment at: llvm/include/llvm/InterfaceStub/ELFObjHandler.h:25
namespace elfabi {
Shouldn't this be in namespace `ifs`?
Comment a
