Re: [PATCH] Fix stack overflow in MSVC unqualified type lookup logic

2016-05-31 Thread Reid Kleckner via cfe-commits
Thanks for the patch and report! Can this check be defeated with mutually recursive class template inheritance? I was thinking something like this: ... template struct FooWrapper : FooTemplated { }; // Full template spec template class FooTemplated : public FooWrapper { ... Maybe we should us

Re: [PATCH] Fix stack overflow in MSVC unqualified type lookup logic

2016-05-30 Thread Will Wilson via cfe-commits
Hi Alexey, On 31 May 2016 at 12:25, Alexey Bataev wrote: > Hi Will, > Thanks for the report and sorry for a delay with answer. Generally, your > patch looks good with some small nits. I can fix some minor issues like > extra braces etc. and commit it if you don't mind. > Sure thing. Commit away

Re: [PATCH] Fix stack overflow in MSVC unqualified type lookup logic

2016-05-30 Thread Alexey Bataev via cfe-commits
Hi Will, Thanks for the report and sorry for a delay with answer. Generally, your patch looks good with some small nits. I can fix some minor issues like extra braces etc. and commit it if you don't mind. Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 28.05.2016

[PATCH] Fix stack overflow in MSVC unqualified type lookup logic

2016-05-27 Thread Will Wilson via cfe-commits
Hi Alexey, A customer encountered a stack overflow in the code from r229817. I've created a small repro for testing the issue and a fix. The fix should also better deal with lookup into partially specialized base templates. Test case included and tested against latest trunk. Let me know if it lo