Re: [PATCH] Use the correct ObjC++ personality

2017-04-01 Thread Benjamin Kramer via cfe-commits
Landed in r299306 with a test case. Yes, even one-liners should have a test case. On Thu, Mar 30, 2017 at 10:30 PM, Jonathan Schleifer via cfe-commits wrote: >> Testcase? > > Shouldn't be necessary for such a simple and extremely obvious one-liner. > > -- > Jonathan >

Re: [PATCH] Use the correct ObjC++ personality

2017-03-30 Thread Jonathan Schleifer via cfe-commits
> Testcase? Shouldn't be necessary for such a simple and extremely obvious one-liner. -- Jonathan ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] Use the correct ObjC++ personality

2017-03-26 Thread Jonathan Roelofs via cfe-commits
On 3/26/17 10:13 AM, Jonathan Schleifer via cfe-commits wrote: Use the correct EH personality for ObjC++ code. Previously, it would just always use the ObjC DWARF personality, even with SjLj or SEH exceptions. diff --git a/lib/CodeGen/CGException.cpp b/lib/CodeGen/CGException.cpp index 228ef

[PATCH] Use the correct ObjC++ personality

2017-03-26 Thread Jonathan Schleifer via cfe-commits
Use the correct EH personality for ObjC++ code. Previously, it would just always use the ObjC DWARF personality, even with SjLj or SEH exceptions. diff --git a/lib/CodeGen/CGException.cpp b/lib/CodeGen/CGException.cpp index 228efec51b..ca1535182e 100644 --- a/lib/CodeGen/CGException.cpp +++ b/li